public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: Santiago Garcia Mantinan <manty@manty.net>,
	linux-kernel@vger.kernel.org, Adam Belay <ambx1@neo.rr.com>
Subject: Re: ALSA in 2.6 failing to find the OPL chip of the sb cards
Date: Mon, 12 Jan 2004 16:31:54 +0100	[thread overview]
Message-ID: <s5hu131b2tx.wl@alsa2.suse.de> (raw)
In-Reply-To: <3FFFA8C3.6040609@keyaccess.nl>

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

At Sat, 10 Jan 2004 08:24:51 +0100,
Rene Herman wrote:
> 
> That is, the driver doesn't complain anymore. Still didn't see the OPL 
> appear in /proc/ioports though (loading with fm_port=0x388 doesn't 
> change that). Haven't investigated further yet, will do.

it's a bug.  the attached patch should fix it.


--
Takashi Iwai <tiwai@suse.de>		ALSA Developer - www.alsa-project.org

[-- Attachment #2: Type: text/plain, Size: 504 bytes --]

--- linux/sound/isa/sb/sb16.c	30 Oct 2003 14:19:30 -0000	1.31
+++ linux/sound/isa/sb/sb16.c	12 Jan 2004 15:30:04 -0000
@@ -483,7 +483,7 @@
 	if (fm_port[dev] > 0 && fm_port[dev] != SNDRV_AUTO_PORT) {
 		if (snd_opl3_create(card, fm_port[dev], fm_port[dev] + 2,
 				    OPL3_HW_OPL3,
-				    fm_port[dev] == port[dev] || fm_port[dev] == 0x388,
+				    acard->fm_res != NULL,
 				    &opl3) < 0) {
 			snd_printk(KERN_ERR PFX "no OPL device at 0x%lx-0x%lx\n",
 				   fm_port[dev], fm_port[dev] + 2);


  parent reply	other threads:[~2004-01-12 15:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-07 21:29 ALSA in 2.6 failing to find the OPL chip of the sb cards Santiago Garcia Mantinan
2004-01-08 17:21 ` Takashi Iwai
2004-01-08 22:42   ` Santiago Garcia Mantinan
2004-01-09 17:17   ` Santiago Garcia Mantinan
2004-01-09 17:37     ` Takashi Iwai
2004-01-09 20:14       ` Santiago Garcia Mantinan
2004-01-10  7:24         ` Rene Herman
2004-01-11  5:33           ` [PATCH] " Rene Herman
2004-01-12 15:35             ` Takashi Iwai
2004-01-13 23:29               ` Adam Belay
2004-01-14 19:07                 ` Adam Belay
2004-01-15  0:36                   ` Rene Herman
2004-01-15 23:35                   ` Rene Herman
2004-01-18 22:26                   ` Santiago Garcia Mantinan
2004-01-12 21:14             ` Santiago Garcia Mantinan
2004-01-12 15:31           ` Takashi Iwai [this message]
2004-01-12 20:51             ` Rene Herman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hu131b2tx.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=ambx1@neo.rr.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manty@manty.net \
    --cc=rene.herman@keyaccess.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox