From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6476ECA9EB7 for ; Mon, 21 Oct 2019 13:15:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F8F72089C for ; Mon, 21 Oct 2019 13:15:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728834AbfJUNPR (ORCPT ); Mon, 21 Oct 2019 09:15:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:43368 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726767AbfJUNPQ (ORCPT ); Mon, 21 Oct 2019 09:15:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 07225B712; Mon, 21 Oct 2019 13:15:14 +0000 (UTC) Date: Mon, 21 Oct 2019 15:15:14 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/2] PCI: Add a helper to check Power Resource Requirements _PR3 existence In-Reply-To: References: <20191018073848.14590-1-kai.heng.feng@canonical.com> <4C18DF4A-FAE8-4762-AF65-F892A4845297@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Oct 2019 10:45:43 +0200, Takashi Iwai wrote: > > On Fri, 18 Oct 2019 10:30:11 +0200, > Kai-Heng Feng wrote: > > > > > > > > > On Oct 18, 2019, at 16:18, Takashi Iwai wrote: > > > > > > On Fri, 18 Oct 2019 09:38:47 +0200, > > > Kai-Heng Feng wrote: > > >> > > >> A driver may want to know the existence of _PR3, to choose different > > >> runtime suspend behavior. A user will be add in next patch. > > >> > > >> This is mostly the same as nouveau_pr3_present(). > > >> > > >> Reported-by: kbuild test robot > > > > > > It's confusing -- this particular change isn't reported by the test > > > bot, but only about the lack of the CONFIG_ACPI ifdef. > > > > Hmm, because the test bot asked to add the tag. > > Yes, but it's only if you add a new fix patch on top of it. > You can write some their credit, too, but basically it'd be enough to > point to the Link tag to the thread. > > > If it's not appropriate will you drop it? I can also send a v7. > > I can modify in my side. Now I merged both patches to for-next branch. thanks, Takashi