From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 1478AC433EF for ; Thu, 14 Jun 2018 12:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C96DC208B8 for ; Thu, 14 Jun 2018 12:34:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C96DC208B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755186AbeFNMeF (ORCPT ); Thu, 14 Jun 2018 08:34:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:43454 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754809AbeFNMeE (ORCPT ); Thu, 14 Jun 2018 08:34:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 180D1AB08; Thu, 14 Jun 2018 12:34:03 +0000 (UTC) Date: Thu, 14 Jun 2018 14:34:02 +0200 Message-ID: From: Takashi Iwai To: Jorge Sanjuan Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ruslan.bilovol@gmail.com Subject: Re: [PATCH 2/2] ALSA: usb-audio: UAC3. Add insertion control for BADD. In-Reply-To: <20180612143201.29988-3-jorge.sanjuan@codethink.co.uk> References: <20180612143201.29988-1-jorge.sanjuan@codethink.co.uk> <20180612143201.29988-3-jorge.sanjuan@codethink.co.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jun 2018 16:32:01 +0200, Jorge Sanjuan wrote: > > The HEADSET ADAPTER profile for BADD devices is meant to support > Insertion Control for the Input and Output Terminals of the headset. > Furthermore, this profile may also include the interrupt status pipe > to report changes on these terminals. > > This patch creates the jack-detect controls for the Headset Adapter > profile and enables the interrupt status pipe creation for BADD devices. > > Signed-off-by: Jorge Sanjuan The changes look good, but I'd prefer splitting this: - A preliminary work to change get_connector_control_name() and build_connector_control() to receive usb_mixer_interface; this is no functional change - Add build_connector_control() calls for UAC3 BADD - Apply snd_usb_mixer_status_create() for UAC3 BADD, too thanks, Takashi