From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751633AbdLETO0 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Dec 2017 14:14:26 -0500
Received: from mx2.suse.de ([195.135.220.15]:60125 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751421AbdLETOZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Dec 2017 14:14:25 -0500
Date: Tue, 05 Dec 2017 20:14:23 +0100
Message-ID: <s5hvahldm28.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Nick Desaulniers" <ndesaulniers@google.com>
Cc: <alsa-devel@alsa-project.org>, <keescook@chromium.org>,
        "Arvind Yadav" <arvind.yadav.cs@gmail.com>,
        "Robb Glasser" <rglasser@google.com>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
        "Markus Elfring" <elfring@users.sourceforge.net>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: pcm: prevent UAF in snd_pcm_info
In-Reply-To: <20171205171657.74392-1-ndesaulniers@google.com>
References: <20171205171657.74392-1-ndesaulniers@google.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 05 Dec 2017 18:16:55 +0100,
Nick Desaulniers wrote:
> 
> From: Robb Glasser <rglasser@google.com>
> 
> When the device descriptor is closed, the `substream->runtime` pointer
> is freed. But another thread may be in the ioctl handler, case
> SNDRV_CTL_IOCTL_PCM_INFO. This case calls snd_pcm_info_user() which
> calls snd_pcm_info() which accesses the now freed `substream->runtime`.
> 
> Signed-off-by: Robb Glasser <rglasser@google.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Looks reasonable.  Applied with Cc to stable now.


thanks,

Takashi

> ---
>  sound/core/pcm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/core/pcm.c b/sound/core/pcm.c
> index 9070f277f8db..09ee8c6b9f75 100644
> --- a/sound/core/pcm.c
> +++ b/sound/core/pcm.c
> @@ -153,7 +153,9 @@ static int snd_pcm_control_ioctl(struct snd_card *card,
>  				err = -ENXIO;
>  				goto _error;
>  			}
> +			mutex_lock(&pcm->open_mutex);
>  			err = snd_pcm_info_user(substream, info);
> +			mutex_unlock(&pcm->open_mutex);
>  		_error:
>  			mutex_unlock(&register_mutex);
>  			return err;
> -- 
> 2.15.0.531.g2ccb3012c9-goog
> 
>