From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753656AbbAMTyk (ORCPT <rfc822;w@1wt.eu>);
	Tue, 13 Jan 2015 14:54:40 -0500
Received: from cantor2.suse.de ([195.135.220.15]:45587 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751346AbbAMTyi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 13 Jan 2015 14:54:38 -0500
Date: Tue, 13 Jan 2015 20:54:36 +0100
Message-ID: <s5hvbka1mo3.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Jim Davis <jim.epost@gmail.com>
Cc: David Henningsson <david.henningsson@canonical.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        linux-next <linux-next@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>, perex <perex@perex.cz>,
        alsa-devel@alsa-project.org
Subject: Re: randconfig build error with next-20150113, in sound/pci/hda/patch_realtek.c
In-Reply-To: <CA+r1ZhjRNChpFtkTiaE6vfYVxWme2FjjPYwsTR9nodhfZ8KU3w@mail.gmail.com>
References: <CA+r1ZhjRNChpFtkTiaE6vfYVxWme2FjjPYwsTR9nodhfZ8KU3w@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Tue, 13 Jan 2015 11:39:12 -0700,
Jim Davis wrote:
> 
> Building with the attached random configuration file,
> 
> sound/built-in.o: In function `alc280_fixup_hp_gpio2_mic_hotkey':
> /home/jim/linux/sound/pci/hda/patch_realtek.c:3512: undefined
> reference to `input_allocate_device'
> /home/jim/linux/sound/pci/hda/patch_realtek.c:3520: undefined
> reference to `input_register_device'
> /home/jim/linux/sound/pci/hda/patch_realtek.c:3522: undefined
> reference to `input_free_device'
> /home/jim/linux/sound/pci/hda/patch_realtek.c:3550: undefined
> reference to `input_unregister_device'
> sound/built-in.o: In function `gpio2_mic_hotkey_event':
> /home/jim/linux/include/linux/input.h:392: undefined reference to `input_event'
> /home/jim/linux/include/linux/input.h:417: undefined reference to `input_event'
> /home/jim/linux/include/linux/input.h:392: undefined reference to `input_event'
> /home/jim/linux/include/linux/input.h:417: undefined reference to `input_event'
> make: *** [vmlinux] Error 1

Thanks.  So this is the case where the audio driver is built-in while
the input driver is module.

I guess the cleanest workaround is just to select INPUT from
SND_HDA_CODEC_REALTEK in sound/pci/hda/Kconfig.  Practically seen,
CONFIG_INPUT is always set, so there must be no real drawback with it.
(And we can reduce a few lines as a bonus.)

David, care to prepare a patch?


thanks,

Takashi