public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sound: pci: asihpi: hpifunc.c: Remove some unused functions
Date: Wed, 31 Dec 2014 17:45:23 +0100	[thread overview]
Message-ID: <s5hvbkrg44c.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAKXHbyOEp=juzjaqsNt9RXn02VYDJXvESK4o_vAhMtFGmK=dHA@mail.gmail.com>

At Wed, 31 Dec 2014 17:41:33 +0100,
Rickard Strandqvist wrote:
> 
> 2014-12-31 17:07 GMT+01:00 Takashi Iwai <tiwai@suse.de>:
> 
> > At Wed, 31 Dec 2014 16:17:02 +0100,
> > Rickard Strandqvist wrote:
> > >
> > > Removes some functions that are not used anywhere:
> >
> > See Eliot's previous reply.  There will be some code changes, so this
> > action is no-go as of now.
> >
> >
> > thanks,
> >
> > Takashi
> >
> 
> 
> Hi Takashi
> 
> I have restored the function hpi_adapter_set_property() that Eliot wanted.
> And I also have diff the files against the linux-next, but that there are
> some notable differences.
> 
> What is it you do not like about my current patch?

More code changes may land in near future, so removing functions isn't
good at all at this moment.  We need to wait until the all things are
settled down.  IOW, forget about this for a while :)

And please add Eliot to Cc at the next time.


thanks,

Takashi

  parent reply	other threads:[~2014-12-31 16:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-31 15:17 [PATCH v2] sound: pci: asihpi: hpifunc.c: Remove some unused functions Rickard Strandqvist
2014-12-31 16:07 ` Takashi Iwai
     [not found]   ` <CAKXHbyOEp=juzjaqsNt9RXn02VYDJXvESK4o_vAhMtFGmK=dHA@mail.gmail.com>
2014-12-31 16:45     ` Takashi Iwai [this message]
     [not found]       ` <CAKXHbyPEr+HOAXB8ibtpYidh_GVD0qAgcQK3A4kXpgVWgLbtQA@mail.gmail.com>
2014-12-31 17:47         ` Takashi Iwai
2014-12-31 21:38           ` Eliot Blennerhassett
2015-01-01  8:03             ` Takashi Iwai
2015-01-01  8:03             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hvbkrg44c.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rickard_strandqvist@spectrumdigital.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox