From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751827AbaLaQp0 (ORCPT ); Wed, 31 Dec 2014 11:45:26 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60908 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750956AbaLaQpZ (ORCPT ); Wed, 31 Dec 2014 11:45:25 -0500 Date: Wed, 31 Dec 2014 17:45:23 +0100 Message-ID: From: Takashi Iwai To: Rickard Strandqvist Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] sound: pci: asihpi: hpifunc.c: Remove some unused functions In-Reply-To: References: <1420039022-10018-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 31 Dec 2014 17:41:33 +0100, Rickard Strandqvist wrote: > > 2014-12-31 17:07 GMT+01:00 Takashi Iwai : > > > At Wed, 31 Dec 2014 16:17:02 +0100, > > Rickard Strandqvist wrote: > > > > > > Removes some functions that are not used anywhere: > > > > See Eliot's previous reply. There will be some code changes, so this > > action is no-go as of now. > > > > > > thanks, > > > > Takashi > > > > > Hi Takashi > > I have restored the function hpi_adapter_set_property() that Eliot wanted. > And I also have diff the files against the linux-next, but that there are > some notable differences. > > What is it you do not like about my current patch? More code changes may land in near future, so removing functions isn't good at all at this moment. We need to wait until the all things are settled down. IOW, forget about this for a while :) And please add Eliot to Cc at the next time. thanks, Takashi