From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161312AbaKNNqr (ORCPT ); Fri, 14 Nov 2014 08:46:47 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33453 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161014AbaKNNqo (ORCPT ); Fri, 14 Nov 2014 08:46:44 -0500 Date: Fri, 14 Nov 2014 14:46:43 +0100 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] ALSA: ice1712: consider error value In-Reply-To: <20141114134502.GA16479@sudip-PC> References: <1415968941-14181-1-git-send-email-sudipm.mukherjee@gmail.com> <20141114134502.GA16479@sudip-PC> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 14 Nov 2014 19:15:02 +0530, Sudip Mukherjee wrote: > > On Fri, Nov 14, 2014 at 02:18:31PM +0100, Takashi Iwai wrote: > > At Fri, 14 Nov 2014 18:12:21 +0530, > > Sudip Mukherjee wrote: > > > > > > earlier we were ignoring the return value of snd_ak4114_create and > > > always returning 0. > > > now we are returning the actual status. revo_init is calling this > > > function, and revo_init is checking the return value. > > > > > > Signed-off-by: Sudip Mukherjee > > > --- > > > > > > change in v3: spec->ak4114 is now dereferenced if we dont get an > > > error value from snd_ak4114_create. > > > > > > change in v4: error value returned according to coding style. > > > > Applied but I had to fix your From address (two others, too). That > > doesn't match with your sign-off. Please fix your git config to have > > a proper author address as same as sign-off. > > i know it does not match. Previously Dan Carpenter also told me the same thing, and I sent a patch from my corporate account. You can find reference of that conversation here https://lkml.org/lkml/2014/9/3/473 > > copying some part from there : > "I have given strict DMARC check for the corporate mail server. DMARC = domain based message authentication. > So the mail i sent reached all the list subscriber from a different server than our designated server, > and as a result it has been marked as spam in many places. I have already received a few complaints regarding that." > > since i do use office resources for patches (though it is not part of my job), so i should atleast put Signed-off to the patches i send. You will see all my patches having different Signed-off and different from adderess. > > again copying from the previous conversation: > "Is there any other way that i send the patch from my personal account, and use my corporate mail in Signed-off-by ... " You just need to put another "From: xxx" in the patch itself. Then git will take it as the author address. Takashi