From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1755182AbYH0Jp5@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755182AbYH0Jp5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Aug 2008 05:45:57 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754058AbYH0Jpt
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 27 Aug 2008 05:45:49 -0400
Received: from ns2.suse.de ([195.135.220.15]:45482 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752741AbYH0Jpt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Aug 2008 05:45:49 -0400
Date: Wed, 27 Aug 2008 11:45:48 +0200
Message-ID: <s5hvdxmkcz7.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Tejun Heo <tj@kernel.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       alsa-devel@alsa-project.org, perex@perex.cz
Subject: Re: [PATCH RESEND] sound: make OSS sound core optional
In-Reply-To: <48B52068.2090502@kernel.org>
References: <48B50E17.4020106@kernel.org>
	<s5hprnubz89.wl%tiwai@suse.de>
	<48B52068.2090502@kernel.org>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 27 Aug 2008 11:37:44 +0200,
Tejun Heo wrote:
> 
> Hello,
> 
> Takashi Iwai wrote:
> >> +config SOUND_OSS_CORE
> >> +	bool
> >> +	default n
> >> +
> >>  source "sound/oss/dmasound/Kconfig"
> > 
> > This seems missing from the scope.
> > But, I think this should be rather in the block "if SOUND_PRIME" below.
> 
> SOUND_OSS_CORE should be turned on if ALSA OSS emul is turned on or
> arch-um hostsound is turned on, both of which can be enabled regardless
> of SOUND_PRIME, no?

Yes, sorry, I didn't cite clearly.  I meant only the last line.
sound/oss/dmasound/Kconfig is included and evaluated outside the block
"if SOUND_PRIME".  Thus, CONFIG_SOUND_OSS_CORE won't be enabled for
drivers in sound/oss/dmasound.

My suggestion is to move that line source sound/oss/dmasound/Kconfig
into the "if SOUND_PRIME" block first, then apply your patch.

Anyway, there are some other minor issues in sound/Kconfig, for
example, why "if !M68K" is there.  We can clean up a bit more.


thanks,

Takashi