From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
torvalds@linux-foundation.org, vinod.koul@intel.com,
liam.r.girdwood@linux.intel.com,
andriy.shevchenko@linux.intel.com, arnd@arndb.de,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/7] Fix Intel audio Kconfig issues
Date: Tue, 21 Nov 2017 18:10:52 +0100 [thread overview]
Message-ID: <s5hwp2jtv4z.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5ho9o07xbr.wl-tiwai@suse.de>
On Sat, 18 Nov 2017 10:25:28 +0100,
Takashi Iwai wrote:
>
> On Sat, 18 Nov 2017 01:01:55 +0100,
> Pierre-Louis Bossart wrote:
> >
> > At the risk of being scolded for the third time in two days by
> > Linux overlords (no hard feelings), here's an attempt to clean
> > things up.
> >
> > The first patch *should* implement what Linus, Takashi and Mark
> > tried to explain by email. There should be no functionality change
> > and could be merged if deemed ok.
> >
> > The rest of the patch series does a more in-depth cleanup and should not
> > be merged without more testing (hence the RFC).
> >
> > The 4th patch is really the most important one, there were nested
> > configs which made no sense to me. I don't know the history which led
> > to such complicated stuff but simpler is better.
> >
> > The last 3 patches are just clean-ups of the machine driver configs,
> > for some reason there is no consistency in the settings so I tried to
> > apply common sense. There might be additional cleanup needed since I
> > don't really get why we need references to LPSS or DESIGNWARE for things
> > which are not visible to a machine driver, we should only depend on IC2 or
> > SPI in my opinion - depending on what the control interface is.
> >
> > I tried to keep things to a minimum in each patch to make the reviews
> > easier, if people want them squashed that's fine by me.
> >
> > I'll do some more testing on my side but I could use feedback. Thanks!
>
> FYI, I've put these to a test branch, test/asoc-intel-kconfig, so that
> 0day bot can catch issues. Let's see.
No news is a good news, it seems that your patchset doesn't break
builds, at least. Let's go ahead!
Takashi
next prev parent reply other threads:[~2017-11-21 17:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 0:01 [RFC PATCH 0/7] Fix Intel audio Kconfig issues Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig Pierre-Louis Bossart
2017-11-18 16:49 ` Takashi Iwai
2017-11-20 16:18 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-21 17:07 ` Takashi Iwai
2017-11-21 21:31 ` Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 2/7] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies Pierre-Louis Bossart
2017-11-18 16:53 ` Andy Shevchenko
2017-11-18 16:55 ` Shevchenko, Andriy
2017-11-20 16:23 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-20 16:58 ` Alan Cox
2017-11-21 12:05 ` Andy Shevchenko
2017-11-20 15:23 ` Alan Cox
2017-11-18 0:01 ` [RFC PATCH 3/7] ASoC: Intel: document what Kconfig options do Pierre-Louis Bossart
2017-11-21 17:09 ` [alsa-devel] " Takashi Iwai
2017-11-21 21:32 ` Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 4/7] ASoC: Intel: Fix nested/unnecessary Kconfig dependencies Pierre-Louis Bossart
2017-11-18 0:02 ` [RFC PATCH 5/7] ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell Pierre-Louis Bossart
2018-01-08 16:22 ` Applied "ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell" to the asoc tree Mark Brown
2017-11-18 0:02 ` [RFC PATCH 6/7] ASoC: Intel: boards: align Kconfig configurations for HiFi2 Pierre-Louis Bossart
2017-11-18 17:08 ` Andy Shevchenko
2017-11-20 16:27 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-18 0:02 ` [RFC PATCH 7/7] ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs Pierre-Louis Bossart
2017-11-18 17:14 ` Andy Shevchenko
2017-11-18 0:09 ` [RFC PATCH 0/7] Fix Intel audio Kconfig issues Linus Torvalds
2017-11-18 9:25 ` Takashi Iwai
2017-11-20 13:28 ` Arnd Bergmann
2017-11-21 17:10 ` Takashi Iwai [this message]
2017-11-21 21:36 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-22 11:54 ` Mark Brown
2017-11-27 14:40 ` [alsa-devel] " Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwp2jtv4z.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).