From: Takashi Iwai <tiwai@suse.de>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [alsa-devel] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
Date: Tue, 22 Aug 2017 17:07:54 +0200 [thread overview]
Message-ID: <s5hwp5v7i9h.wl-tiwai@suse.de> (raw)
In-Reply-To: <b434f976-33a1-7ced-55b5-b55487f2fb14@users.sourceforge.net>
On Tue, 22 Aug 2017 17:03:00 +0200,
SF Markus Elfring wrote:
>
> >> * I find it a bit safer when the error predicate is “return value != 0”.
> >
> > Can't agree.
>
> How do you think about to reduce the probability that positive return values
> will accidentally be interpreted as a successful function execution.
It's not zero.
> > And I have no interest to continue bike-shedding, sorry.
>
> I do not like that you prefer to put this technical detail into such
> a communication category.
>
>
> > You can't convince me regarding this.
>
> Would you still like to integrate the proposed refactoring with the use
> of previous failure predicates then?
That's fine.
But, please don't forget what others already mentioned.
For example, Joe Perches suggested to put a blank line before the
label for your patches. But you completely ignored it and did the
same again.
thanks,
Takashi
next prev parent reply other threads:[~2017-08-22 15:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 12:10 [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe() SF Markus Elfring
2017-08-22 12:16 ` Dan Carpenter
2017-08-22 12:28 ` Takashi Iwai
2017-08-22 12:47 ` SF Markus Elfring
2017-08-22 12:55 ` [alsa-devel] " Takashi Iwai
2017-08-22 13:15 ` SF Markus Elfring
2017-08-22 14:07 ` Takashi Iwai
2017-08-22 14:36 ` SF Markus Elfring
2017-08-22 14:49 ` Takashi Iwai
2017-08-22 15:03 ` SF Markus Elfring
2017-08-22 15:07 ` Takashi Iwai [this message]
2017-08-22 15:47 ` [PATCH v3] " SF Markus Elfring
2017-08-22 15:59 ` Takashi Iwai
2017-08-22 14:00 ` [PATCH v2] " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwp5v7i9h.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox