From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751483AbcL1PGl (ORCPT ); Wed, 28 Dec 2016 10:06:41 -0500 Received: from mx2.suse.de ([195.135.220.15]:60489 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034AbcL1PGk (ORCPT ); Wed, 28 Dec 2016 10:06:40 -0500 Date: Wed, 28 Dec 2016 16:06:38 +0100 Message-ID: From: Takashi Iwai To: "Kees Cook" Cc: , , "Jaroslav Kysela" Subject: Re: [PATCH] ALSA: use designated initializers In-Reply-To: <20161217005944.GA140281@beast> References: <20161217005944.GA140281@beast> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 17 Dec 2016 01:59:44 +0100, Kees Cook wrote: > > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook Applied, thanks. Takashi > --- > sound/synth/emux/emux_seq.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/sound/synth/emux/emux_seq.c b/sound/synth/emux/emux_seq.c > index a0209204ae48..55579f6b8cb2 100644 > --- a/sound/synth/emux/emux_seq.c > +++ b/sound/synth/emux/emux_seq.c > @@ -33,13 +33,13 @@ static int snd_emux_unuse(void *private_data, struct snd_seq_port_subscribe *inf > * MIDI emulation operators > */ > static struct snd_midi_op emux_ops = { > - snd_emux_note_on, > - snd_emux_note_off, > - snd_emux_key_press, > - snd_emux_terminate_note, > - snd_emux_control, > - snd_emux_nrpn, > - snd_emux_sysex, > + .note_on = snd_emux_note_on, > + .note_off = snd_emux_note_off, > + .key_press = snd_emux_key_press, > + .note_terminate = snd_emux_terminate_note, > + .control = snd_emux_control, > + .nrpn = snd_emux_nrpn, > + .sysex = snd_emux_sysex, > }; > > > -- > 2.7.4 > > > -- > Kees Cook > Nexus Security >