From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758774AbcAKJC1 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jan 2016 04:02:27 -0500
Received: from mx2.suse.de ([195.135.220.15]:50114 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752809AbcAKJCY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jan 2016 04:02:24 -0500
Date: Mon, 11 Jan 2016 10:02:21 +0100
Message-ID: <s5hwprgcwv6.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: PC Liao <pc.liao@mediatek.com>
Cc: <broonie@kernel.org>, <srv_heupstream@mediatek.com>,
        <linux-mediatek@lists.infradead.org>, <s.hauer@pengutronix.de>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <alsa-devel@alsa-project.org>, <koro.chen@mediatek.com>,
        Hidalgo Huang <hidalgo.huang@mediatek.com>
Subject: Re: [PATCH] ASoC: mediatek: Enable 33bit memory address to support 4GB DRAM
In-Reply-To: <1452499250-5202-1-git-send-email-pc.liao@mediatek.com>
References: <1452499250-5202-1-git-send-email-pc.liao@mediatek.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 11 Jan 2016 09:00:50 +0100,
PC Liao wrote:
> 
> @@ -603,7 +606,10 @@ static int mtk_afe_dais_hw_params(struct snd_pcm_substream *substream,
>  	if (ret < 0)
>  		return ret;
>  
> -	memif->phys_buf_addr = substream->runtime->dma_addr;
> +	if (sizeof(dma_addr_t) > 4)
> +		msb_at_bit33 = (substream->runtime->dma_addr & 0x100000000) ? 1 : 0;

Better to put a proper suffix for the constant over 32bit.

Or use upper_32_bits().  Then sizeof() check can be omitted, as the
compiler should be smart enough to know it beforehand.


Takashi