From: Takashi Iwai <tiwai@suse.de>
To: Daniel Mack <daniel@caiaq.de>
Cc: Jiri Slaby <jslaby@suse.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
jirislaby@gmail.com, Clemens Ladisch <clemens@ladisch.de>
Subject: Re: [PATCH] SOUND: usb/endpoint, fix dangling pointer use
Date: Mon, 21 Jun 2010 17:09:03 +0200 [thread overview]
Message-ID: <s5hwrts2zjk.wl%tiwai@suse.de> (raw)
In-Reply-To: <20100621150515.GB17833@buzzloop.caiaq.de>
At Mon, 21 Jun 2010 17:05:16 +0200,
Daniel Mack wrote:
>
> On Mon, Jun 21, 2010 at 05:03:21PM +0200, Jiri Slaby wrote:
> > Stanse found that in snd_usb_parse_audio_endpoints, there is a
> > dangling pointer dereference. When snd_usb_parse_audio_format fails,
> > fp is freed, and continue invoked. On the next loop, there is
> > "fp && fp->altsetting == 1 && fp->channels == 1" test, but fp is set
> > from the last iteration (but is bogus) and thus ilegally dereferenced.
> >
> > Set fp to NULL before "continue".
>
> Oh, absolutely. Thanks.
>
> > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>
> Acked-by: Daniel Mack <daniel@caiaq.de>
>
> I think this should go thru the ALSA tree.
Yep, I applied it now. Thanks!
Takashi
prev parent reply other threads:[~2010-06-21 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 15:03 [PATCH] SOUND: usb/endpoint, fix dangling pointer use Jiri Slaby
2010-06-21 15:05 ` Daniel Mack
2010-06-21 15:09 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwrts2zjk.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=daniel@caiaq.de \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox