From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265226AbUHPOWs (ORCPT ); Mon, 16 Aug 2004 10:22:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266048AbUHPOWs (ORCPT ); Mon, 16 Aug 2004 10:22:48 -0400 Received: from cantor.suse.de ([195.135.220.2]:27528 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S265226AbUHPOWq (ORCPT ); Mon, 16 Aug 2004 10:22:46 -0400 Date: Mon, 16 Aug 2004 16:19:49 +0200 Message-ID: From: Takashi Iwai To: Kurt Garloff Cc: Chris Wright , Linux kernel list Subject: Re: [PATCH] [LSM] Rework LSM hooks In-Reply-To: <20040811222213.GB14744@tpkurt.garloff.de> References: <20040810130009.P1924@build.pdx.osdl.net> <20040810131217.Q1924@build.pdx.osdl.net> <20040811222213.GB14744@tpkurt.garloff.de> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 12 Aug 2004 00:22:13 +0200, Kurt Garloff wrote: > > [1 ] > On Tue, Aug 10, 2004 at 01:12:17PM -0700, Chris Wright wrote: > > * James Morris (jmorris@redhat.com) wrote: > > > On Tue, 10 Aug 2004, Chris Wright wrote: > > > > Is this new (i.e. you just did this)? It's basically the same result we > > > > had from a few years ago. > > > > > > Yes, did it today. > > > > Thanks, James. Since these are the only concrete numbers and they are > > in the noise, I see no compelling reason to change to unlikely(). > > Well, you may want to drop the unlikely if you dislike it. It can be dependent on CONFIG_SECURITY_SELINUX_BOOTPARAM_VALUE? (E.g. use unlikely() when it's 0) Takashi