From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23911C433F5 for ; Mon, 28 Feb 2022 16:58:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238074AbiB1Q6m (ORCPT ); Mon, 28 Feb 2022 11:58:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237903AbiB1Q6j (ORCPT ); Mon, 28 Feb 2022 11:58:39 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C8B12DD69 for ; Mon, 28 Feb 2022 08:58:00 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 083791F446; Mon, 28 Feb 2022 16:57:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646067479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7SQezWrefdfyxYAuqsK1Ki9iYBM12AVThkoZEyjK+Zc=; b=ZPU88y8ZF6FXH0afyVvu6HAMJgRMsZF3hNWU2XICwxzXL/snhtsxGXhAVRF2gokDO9Gom+ px+XSjFF7ndXCbfn1l5fBt8sbOzQlKzZKsalRzM6QSv1AXR9RbevP2iOkOEtYoRrJE3sLN YW/VZqwoL83En2w7OJgirSXFdUWizaA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646067479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7SQezWrefdfyxYAuqsK1Ki9iYBM12AVThkoZEyjK+Zc=; b=nBQswWkpY13GEqau7Zffx2DBRTDruvMIeiXXZgmJknRXIVZW1tru+BRU7vtJLxNiMDhtrT 4AzaOm7mF03FIGCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id C745FA3B8B; Mon, 28 Feb 2022 16:57:58 +0000 (UTC) Date: Mon, 28 Feb 2022 17:57:58 +0100 Message-ID: From: Takashi Iwai To: Joe Perches Cc: Meng Tang , perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] ALSA: core: Remove redundant variable and return the last statement In-Reply-To: <1760d9be590e18b5cccceef6e049651c69556c37.camel@perches.com> References: <20220228050253.1649-1-tangmeng@uniontech.com> <20220228050253.1649-2-tangmeng@uniontech.com> <1760d9be590e18b5cccceef6e049651c69556c37.camel@perches.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Feb 2022 17:39:21 +0100, Joe Perches wrote: > > On Mon, 2022-02-28 at 17:02 +0100, Takashi Iwai wrote: > > On Mon, 28 Feb 2022 06:20:45 +0100, Joe Perches wrote: > > > On Mon, 2022-02-28 at 13:02 +0800, Meng Tang wrote: > > > > Return the result from file->f_op->open() directly instead of > > > > taking this in another redundant variable. Make the typical > > > > return the last statement, return early and reduce the indentation > > > > too. > > > > > > > > Signed-off-by: Meng Tang > > > > Signed-off-by: Joe Perches > > > > > > Hi Meng Tang. > > > > > > For the next time: it's not necessary (or even good) to add a sign-off > > > for another person unless they specifically authorize one. > > > > > > You wrote and are submitting these changes, I merely gave you simple > > > suggestions as to how you could improve them. > > > > Joe, would you like to drop your S-o-b lines from those two patches? > > Or shall I keep them? > > > > thanks, > > > > Takashi > > Hi Takashi. > > Nominally, the sign-off-by chain shows who pushed these changes upstream > and I did not and I am not an upstream aggregator. > > But whatever you choose is OK. > It's not really a concern to me. > I do think these changes are ok. OK, I dropped S-o-b lines and applied the patches now. thanks, Takashi