From: Takashi Iwai <tiwai@suse.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Udo van den Heuvel <udovdh@xs4all.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org, Dan Murphy <dmurphy@ti.com>,
moderated for non-subscribers <alsa-devel@alsa-project.org>
Subject: Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)
Date: Wed, 14 Oct 2020 10:17:08 +0200 [thread overview]
Message-ID: <s5hzh4pkyrf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201014081305.GD29881@amd>
On Wed, 14 Oct 2020 10:13:05 +0200,
Pavel Machek wrote:
>
> On Wed 2020-10-14 10:08:27, Takashi Iwai wrote:
> > On Wed, 14 Oct 2020 09:54:59 +0200,
> > Pavel Machek wrote:
> > >
> > > Hi!
> > >
> > > > >>> I.e.: it looks like I will lose some funcionality when I disable
> > > > >>> SND_HDA_CODEC_REALTEK.
> > > > >>
> > > > >> OK. At present you can't have it both ways, i.e., SND_HDA_CODEC_REALTEK
> > > > >> with no LEDS. That driver apparently wants LEDS.
> > > > >
> > > > > Thanks but why have I gone for years without LEDS?
> > > > > I do not need LEDS, I do not want LEDS, I do not have LEDS (that are
> > > > > visible, usable, etc).
> > > > >
> > > > > Please make this selectable instead of forcing more bulk into my
> > > >> kernel.
> > >
> > > LED core is not that big, and this avoided some rather "interesting"
> > > hacks IIRC. If Udo wants more config complexity, lets first make him
> > > measure the benefits, second submit a patch.
> > >
> > > But I'd suggest to just live with it.
> > >
> > > And yes, we should probably get rid of "CONFIG_NEW_LEDS" symbol. That
> > > one is actually useless.
> >
> > IIRC, this was needed for the reverse selection of CONFIG_LEDS_CLASS
> > and co. But if it's really useless, I'll happily delete it.
>
> It is needed for now. It is just something we should remove in
> future. CONFIG options are not that cheap...
Ah I see. Yes, the config itself is superfluous.
thanks,
Takashi
prev parent reply other threads:[~2020-10-14 8:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 9:24 disabling CONFIG_LED_CLASS Udo van den Heuvel
2020-10-13 13:24 ` Udo van den Heuvel
2020-10-13 15:53 ` Randy Dunlap
2020-10-13 16:03 ` Randy Dunlap
2020-10-14 4:29 ` Udo van den Heuvel
2020-10-14 4:34 ` Randy Dunlap
2020-10-14 4:39 ` Udo van den Heuvel
2020-10-14 4:49 ` Randy Dunlap
2020-10-14 4:56 ` Udo van den Heuvel
2020-10-14 5:07 ` Randy Dunlap
2020-10-14 5:16 ` Udo van den Heuvel
2020-10-14 5:54 ` disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK) Randy Dunlap
2020-10-14 7:49 ` Takashi Iwai
2020-10-14 7:51 ` Takashi Iwai
2020-10-14 7:58 ` Pavel Machek
2020-10-14 8:05 ` Udo van den Heuvel
2020-10-14 8:11 ` Pavel Machek
2020-10-14 8:22 ` Udo van den Heuvel
2020-10-14 8:27 ` Pavel Machek
2020-10-14 8:34 ` Udo van den Heuvel
2020-10-14 8:37 ` Pavel Machek
2020-10-19 8:35 ` Udo van den Heuvel
2020-10-19 10:58 ` Marek Behún
2020-10-14 8:06 ` Takashi Iwai
2020-10-14 7:54 ` Pavel Machek
2020-10-14 8:08 ` Takashi Iwai
2020-10-14 8:13 ` Pavel Machek
2020-10-14 8:17 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzh4pkyrf.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
--cc=udovdh@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox