From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECBF2C32751 for ; Wed, 31 Jul 2019 12:53:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8F6E208E4 for ; Wed, 31 Jul 2019 12:53:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387965AbfGaMxk (ORCPT ); Wed, 31 Jul 2019 08:53:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:52514 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387881AbfGaMxj (ORCPT ); Wed, 31 Jul 2019 08:53:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E3E90AF35; Wed, 31 Jul 2019 12:53:37 +0000 (UTC) Date: Wed, 31 Jul 2019 14:53:37 +0200 Message-ID: From: Takashi Iwai To: Greg KH Cc: Qian Cai , mcgrof@kernel.org, issor.oruam@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: fix -Wunused-function compiler warnings In-Reply-To: <20190731124437.GA4786@kroah.com> References: <1563888722-24141-1-git-send-email-cai@lca.pw> <20190731124437.GA4786@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 Jul 2019 14:44:37 +0200, Greg KH wrote: > > On Tue, Jul 23, 2019 at 09:32:02AM -0400, Qian Cai wrote: > > The commit 5342e7093ff2 ("firmware: Factor out the paged buffer handling > > code") introduced a few compilation warnings when > > CONFIG_FW_LOADER_USER_HELPER=n due to fw_grow_paged_buf() and > > fw_grow_paged_buf() are only used in > > drivers/base/firmware_loader/fallback.c, and the later will only be > > built if CONFIG_FW_LOADER_USER_HELPER=y. > > > > In file included from drivers/base/firmware_loader/main.c:41: > > drivers/base/firmware_loader/firmware.h:145:12: warning: > > 'fw_map_paged_buf' defined but not used [-Wunused-function] > > static int fw_map_paged_buf(struct fw_priv *fw_priv) { return -ENXIO; } > > ^~~~~~~~~~~~~~~~ > > drivers/base/firmware_loader/firmware.h:144:12: warning: > > 'fw_grow_paged_buf' defined but not used [-Wunused-function] > > static int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed) > > { return -ENXIO; } > > > > Fix it by removing those unused functions all together when > > CONFIG_FW_LOADER_USER_HELPER=n. > > > > Fixes: 5342e7093ff2 ("firmware: Factor out the paged buffer handling code") > > Signed-off-by: Qian Cai > > --- > > drivers/base/firmware_loader/firmware.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h > > index 842e63f19f22..e74117bf8587 100644 > > --- a/drivers/base/firmware_loader/firmware.h > > +++ b/drivers/base/firmware_loader/firmware.h > > @@ -141,8 +141,6 @@ int assign_fw(struct firmware *fw, struct device *device, > > int fw_map_paged_buf(struct fw_priv *fw_priv); > > #else > > static inline void fw_free_paged_buf(struct fw_priv *fw_priv) {} > > -static int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed) { return -ENXIO; } > > -static int fw_map_paged_buf(struct fw_priv *fw_priv) { return -ENXIO; } > > #endif > > > > #endif /* __FIRMWARE_LOADER_H */ > > -- > > 1.8.3.1 > > > > Is this still needed with 5.3-rc2? If so, please rebase and resend as > it does not apply to there. This should have been already covered by my follow-up patch, commit 333a2101f47c "firmware: Fix missing inline" thanks, Takashi