public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Dan Carpenter" <dan.carpenter@oracle.com>
Cc: "SF Markus Elfring" <elfring@users.sourceforge.net>,
	<alsa-devel@alsa-project.org>, "Jaroslav Kysela" <perex@perex.cz>,
	<kernel-janitors@vger.kernel.org>,
	"LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
Date: Tue, 22 Aug 2017 14:28:12 +0200	[thread overview]
Message-ID: <s5hziar9483.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170822121625.syvr64kwyh5xjexg@mwanda>

On Tue, 22 Aug 2017 14:16:25 +0200,
Dan Carpenter wrote:
> 
>   	err = snd_card_register(card);
> > -	if (err < 0) {
> > +	if (err) {
> > +free_card:
> >  		snd_card_free(card);
> >  		return err;
> >  	}
> 
> I thought we agreed, yesterday, to never use this style of error
> handling?

Yeah, this is definitely no-go.

Also, please don't omit the negative value check.


thanks,

Takashi

  reply	other threads:[~2017-08-22 12:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 12:10 [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe() SF Markus Elfring
2017-08-22 12:16 ` Dan Carpenter
2017-08-22 12:28   ` Takashi Iwai [this message]
2017-08-22 12:47     ` SF Markus Elfring
2017-08-22 12:55       ` [alsa-devel] " Takashi Iwai
2017-08-22 13:15         ` SF Markus Elfring
2017-08-22 14:07           ` Takashi Iwai
2017-08-22 14:36             ` SF Markus Elfring
2017-08-22 14:49               ` Takashi Iwai
2017-08-22 15:03                 ` SF Markus Elfring
2017-08-22 15:07                   ` Takashi Iwai
2017-08-22 15:47                     ` [PATCH v3] " SF Markus Elfring
2017-08-22 15:59                       ` Takashi Iwai
2017-08-22 14:00     ` [PATCH v2] " SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hziar9483.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dan.carpenter@oracle.com \
    --cc=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox