From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Jaya Kumar <jayakumar.alsa@gmail.com>,
kernel-janitors@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ALSA: cs5535audio: use named constants for pci_power_t values
Date: Sun, 05 Jan 2014 11:44:03 +0100 [thread overview]
Message-ID: <s5hzjnabte4.wl%tiwai@suse.de> (raw)
In-Reply-To: <1388706031-22180-3-git-send-email-Julia.Lawall@lip6.fr>
At Fri, 3 Jan 2014 00:40:30 +0100,
Julia Lawall wrote:
>
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression pdev;
> @@
>
> pci_set_power_state(pdev,
> - 3
> + PCI_D3hot
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks, applied.
Takashi
>
> ---
> sound/pci/cs5535audio/cs5535audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/cs5535audio/cs5535audio.c b/sound/pci/cs5535audio/cs5535audio.c
> index 902bebd..c0d2835 100644
> --- a/sound/pci/cs5535audio/cs5535audio.c
> +++ b/sound/pci/cs5535audio/cs5535audio.c
> @@ -253,7 +253,7 @@ static irqreturn_t snd_cs5535audio_interrupt(int irq, void *dev_id)
> static int snd_cs5535audio_free(struct cs5535audio *cs5535au)
> {
> synchronize_irq(cs5535au->irq);
> - pci_set_power_state(cs5535au->pci, 3);
> + pci_set_power_state(cs5535au->pci, PCI_D3hot);
>
> if (cs5535au->irq >= 0)
> free_irq(cs5535au->irq, cs5535au);
>
next prev parent reply other threads:[~2014-01-05 10:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 23:40 [PATCH 0/3] use named constants for pci_power_t values Julia Lawall
2014-01-02 23:40 ` [PATCH 1/3] mfd: sta2x11-mfd: " Julia Lawall
2014-01-06 11:01 ` Lee Jones
2014-01-06 11:17 ` Julia Lawall
2014-01-06 11:49 ` Lee Jones
2014-01-02 23:40 ` [PATCH 2/3] ALSA: cs5535audio: " Julia Lawall
2014-01-05 10:44 ` Takashi Iwai [this message]
2014-01-02 23:40 ` [PATCH 3/3] smsc9420: " Julia Lawall
2014-01-04 0:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzjnabte4.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=jayakumar.alsa@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox