* [2.6 patch] fix sound/isa/gus/interwave.c compile with PNP=n
@ 2005-02-06 18:44 Adrian Bunk
2005-02-10 11:36 ` [Alsa-devel] " Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2005-02-06 18:44 UTC (permalink / raw)
To: perex; +Cc: alsa-devel, emmanuel.colbus@ensimag.imag.fr, linux-kernel
Emmanuel Colbus sent this patch one month ago with the following
description:
There is a trivial bug in the file sound/isa/gus/interwave.c .
The variable isapnp is defined only if CONFIG_PNP is enabled, but it is
always used few lines after.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- a/sound/isa/gus/interwave.c Fri Dec 24 22:34:58 2004
+++ b/sound/isa/gus/interwave.c Wed Jan 5 14:06:53 2005
@@ -79,8 +79,10 @@
MODULE_PARM_DESC(id, "ID string for InterWave soundcard.");
module_param_array(enable, bool, NULL, 0444);
MODULE_PARM_DESC(enable, "Enable InterWave soundcard.");
+#ifdef CONFIG_PNP
module_param_array(isapnp, bool, NULL, 0444);
MODULE_PARM_DESC(isapnp, "ISA PnP detection for specified soundcard.");
+#endif
module_param_array(port, long, NULL, 0444);
MODULE_PARM_DESC(port, "Port # for InterWave driver.");
#ifdef SNDRV_STB
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Alsa-devel] [2.6 patch] fix sound/isa/gus/interwave.c compile with PNP=n
2005-02-06 18:44 [2.6 patch] fix sound/isa/gus/interwave.c compile with PNP=n Adrian Bunk
@ 2005-02-10 11:36 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2005-02-10 11:36 UTC (permalink / raw)
To: Adrian Bunk
Cc: perex, alsa-devel, emmanuel.colbus@ensimag.imag.fr, linux-kernel
At Sun, 6 Feb 2005 19:44:21 +0100,
Adrian Bunk wrote:
>
> Emmanuel Colbus sent this patch one month ago with the following
> description:
>
> There is a trivial bug in the file sound/isa/gus/interwave.c .
> The variable isapnp is defined only if CONFIG_PNP is enabled, but it is
> always used few lines after.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Thanks, I applied to ALSA tree.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-02-10 11:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-06 18:44 [2.6 patch] fix sound/isa/gus/interwave.c compile with PNP=n Adrian Bunk
2005-02-10 11:36 ` [Alsa-devel] " Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox