public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: Jaroslav Kysela <perex@suse.cz>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix weird placement of static keyword in sound/core/pcm_memory.c
Date: Thu, 25 Nov 2004 12:45:35 +0100	[thread overview]
Message-ID: <s5hzn16nodc.wl@alsa2.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0411240058410.3389@dragon.hygekrogen.localhost>

At Wed, 24 Nov 2004 01:04:52 +0100 (CET),
Jesper Juhl wrote:
> 
> 
> This patch moves the 'static' keyword to the beginning of the declaration 
> to eliminate the following warning when building with gcc -W
> sound/core/pcm_memory.c:40: warning: `static' is not at beginning of declaration
> 
> This has no actal imact on the code, but it's one less warning to sift 
> through when looking for potential trouble-code with -W
> I have a hard time thinking of a reason to not apply this trivial patch :)

Thanks, I applied your patch to ALSA tree now.


Takashi

      reply	other threads:[~2004-11-27  6:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-24  0:04 [PATCH] fix weird placement of static keyword in sound/core/pcm_memory.c Jesper Juhl
2004-11-25 11:45 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hzn16nodc.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=juhl-lkml@dif.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox