From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261439AbUK0G6m (ORCPT ); Sat, 27 Nov 2004 01:58:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261195AbUKZTG5 (ORCPT ); Fri, 26 Nov 2004 14:06:57 -0500 Received: from zeus.kernel.org ([204.152.189.113]:32190 "EHLO zeus.kernel.org") by vger.kernel.org with ESMTP id S261273AbUKZTGj (ORCPT ); Fri, 26 Nov 2004 14:06:39 -0500 Date: Thu, 25 Nov 2004 12:45:35 +0100 Message-ID: From: Takashi Iwai To: Jesper Juhl Cc: Jaroslav Kysela , linux-kernel Subject: Re: [PATCH] fix weird placement of static keyword in sound/core/pcm_memory.c In-Reply-To: References: User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 24 Nov 2004 01:04:52 +0100 (CET), Jesper Juhl wrote: > > > This patch moves the 'static' keyword to the beginning of the declaration > to eliminate the following warning when building with gcc -W > sound/core/pcm_memory.c:40: warning: `static' is not at beginning of declaration > > This has no actal imact on the code, but it's one less warning to sift > through when looking for potential trouble-code with -W > I have a hard time thinking of a reason to not apply this trivial patch :) Thanks, I applied your patch to ALSA tree now. Takashi