[PATCH] fix weird placement of static keyword in sound/core/pcm_memory.c

[PATCH] fix weird placement of static keyword in sound/core/pcm_memory.c

[Jesper Juhl]

This patch moves the 'static' keyword to the beginning of the declaration 
to eliminate the following warning when building with gcc -W
sound/core/pcm_memory.c:40: warning: `static' is not at beginning of declaration

This has no actal imact on the code, but it's one less warning to sift 
through when looking for potential trouble-code with -W
I have a hard time thinking of a reason to not apply this trivial patch :)


Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>

diff -up linux-2.6.10-rc2-bk6-orig/sound/core/pcm_memory.c linux-2.6.10-rc2-bk6/sound/core/pcm_memory.c
--- linux-2.6.10-rc2-bk6-orig/sound/core/pcm_memory.c	2004-10-18 23:54:39.000000000 +0200
+++ linux-2.6.10-rc2-bk6/sound/core/pcm_memory.c	2004-11-24 00:57:06.000000000 +0100
@@ -37,7 +37,7 @@ static int maximum_substreams = 4;
 module_param(maximum_substreams, int, 0444);
 MODULE_PARM_DESC(maximum_substreams, "Maximum substreams with preallocated DMA memory.");
 
-const static size_t snd_minimum_buffer = 16384;
+static const size_t snd_minimum_buffer = 16384;
 
 
 /*

Re: [PATCH] fix weird placement of static keyword in sound/core/pcm_memory.c

[Takashi Iwai]

At Wed, 24 Nov 2004 01:04:52 +0100 (CET),
Jesper Juhl wrote:
> 
> 
> This patch moves the 'static' keyword to the beginning of the declaration 
> to eliminate the following warning when building with gcc -W
> sound/core/pcm_memory.c:40: warning: `static' is not at beginning of declaration
> 
> This has no actal imact on the code, but it's one less warning to sift 
> through when looking for potential trouble-code with -W
> I have a hard time thinking of a reason to not apply this trivial patch :)

Thanks, I applied your patch to ALSA tree now.


Takashi