Re: [PATCH] Add pci_save_state() to ALSA

[Takashi Iwai <tiwai@suse.de>]

At Fri, 12 Nov 2004 21:00:30 +0800,
Zhu, Yi wrote:
> 
> Takashi Iwai wrote:
> > pci_save_state() is called internally in
> > drivers/pci/pci-driver.c:pci_device_suspend(), so it's redundant.
> > 
> >> My laptop doesn't resume (gets what I assume is an ACPI timeout and
> >> hangs solid) without this small obvious patch.
> > 
> > I'm wondering how this can fix your problem...
> 
> For example, some devices call pci_save_state before pci_disable_device
> in
> ->suspend, but don't pci_enable_device in ->resume. This works before,
> but 
> is broken after the pci_save_state() change. We need to find those
> drivers out
> and change the individual drivers instead of this simple fix.

But pci_save_state() is called again after the driver's suspend
callback is called.  So, the final saved state must be anyway same.

> Martin, which sound driver do you use?

Yep that's important to know.


Takashi