From: Takashi Iwai <tiwai@suse.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@zip.com.au>,
Patrick Mochel <mochel@digitalimplant.org>,
benh@kernel.crashing.org, david-b@pacbell.net
Subject: Re: [patch] enums to clear suspend-state confusion
Date: Mon, 16 Aug 2004 16:09:28 +0200 [thread overview]
Message-ID: <s5hzn4v9ntz.wl@alsa2.suse.de> (raw)
In-Reply-To: <20040812120220.GA30816@elf.ucw.cz>
At Thu, 12 Aug 2004 14:02:21 +0200,
Pavel Machek wrote:
>
> Hi!
>
> This patch should clear up some confusion between driver model and
> drivers people, and also prepares way to add runtime power managment
> later. Please apply,
(snip)
> --- linux-mm/include/linux/pci.h 2004-07-28 22:43:31.000000000 +0200
> +++ linux-delme/include/linux/pci.h 2004-08-12 13:41:12.000000000 +0200
> @@ -637,7 +637,7 @@
> const struct pci_device_id *id_table; /* must be non-NULL for probe to be called */
> int (*probe) (struct pci_dev *dev, const struct pci_device_id *id); /* New device inserted */
> void (*remove) (struct pci_dev *dev); /* Device removed (NULL if not a hot-plug capable driver) */
> - int (*suspend) (struct pci_dev *dev, u32 state); /* Device suspended */
> + int (*suspend) (struct pci_dev *dev, suspend_state_t reason); /* Device suspended */
Does this mean that each driver needs rewrite of suspend callback?
Takashi
next prev parent reply other threads:[~2004-08-16 14:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-12 12:02 [patch] enums to clear suspend-state confusion Pavel Machek
2004-08-16 0:59 ` Andrew Morton
2004-08-16 6:25 ` Pavel Machek
2004-08-16 14:09 ` Takashi Iwai [this message]
2004-08-16 20:11 ` Pavel Machek
2004-08-17 21:25 ` Pavel Machek
2004-08-17 22:27 ` Andrew Morton
2004-08-17 22:37 ` Pavel Machek
2004-08-17 23:12 ` Andrew Morton
2004-08-18 0:27 ` Pavel Machek
2004-08-18 2:04 ` Benjamin Herrenschmidt
2004-08-18 6:12 ` Pavel Machek
2004-08-18 6:55 ` Benjamin Herrenschmidt
2004-08-18 13:03 ` Pavel Machek
2004-08-18 14:29 ` Patrick Mochel
2004-08-18 15:17 ` David Brownell
2004-08-18 20:47 ` Pavel Machek
2004-08-18 17:31 ` Alan Cox
2004-08-18 18:28 ` David Brownell
2004-08-18 20:35 ` Pavel Machek
2004-08-18 6:26 ` Pavel Machek
2004-08-18 6:30 ` Andrew Morton
2004-08-18 10:22 ` Takashi Iwai
[not found] <566B962EB122634D86E6EE29E83DD808182C3774@hdsmsx403.hd.intel.com>
2004-08-19 5:59 ` Len Brown
2004-08-19 8:19 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzn4v9ntz.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=akpm@zip.com.au \
--cc=benh@kernel.crashing.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox