From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267641AbUHPOKV (ORCPT ); Mon, 16 Aug 2004 10:10:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267643AbUHPOKV (ORCPT ); Mon, 16 Aug 2004 10:10:21 -0400 Received: from cantor.suse.de ([195.135.220.2]:64640 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S267641AbUHPOKQ (ORCPT ); Mon, 16 Aug 2004 10:10:16 -0400 Date: Mon, 16 Aug 2004 16:09:28 +0200 Message-ID: From: Takashi Iwai To: Pavel Machek Cc: kernel list , Andrew Morton , Patrick Mochel , benh@kernel.crashing.org, david-b@pacbell.net Subject: Re: [patch] enums to clear suspend-state confusion In-Reply-To: <20040812120220.GA30816@elf.ucw.cz> References: <20040812120220.GA30816@elf.ucw.cz> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 12 Aug 2004 14:02:21 +0200, Pavel Machek wrote: > > Hi! > > This patch should clear up some confusion between driver model and > drivers people, and also prepares way to add runtime power managment > later. Please apply, (snip) > --- linux-mm/include/linux/pci.h 2004-07-28 22:43:31.000000000 +0200 > +++ linux-delme/include/linux/pci.h 2004-08-12 13:41:12.000000000 +0200 > @@ -637,7 +637,7 @@ > const struct pci_device_id *id_table; /* must be non-NULL for probe to be called */ > int (*probe) (struct pci_dev *dev, const struct pci_device_id *id); /* New device inserted */ > void (*remove) (struct pci_dev *dev); /* Device removed (NULL if not a hot-plug capable driver) */ > - int (*suspend) (struct pci_dev *dev, u32 state); /* Device suspended */ > + int (*suspend) (struct pci_dev *dev, suspend_state_t reason); /* Device suspended */ Does this mean that each driver needs rewrite of suspend callback? Takashi