From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D13720DD51 for ; Sun, 5 Jul 2026 02:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783217142; cv=none; b=NnEHb8/qU+bBMkdjNmS+8ntE+EWvSH1+vMKntH7zKWK3VFlrPYG5Nal21+CtSdhiO6OzpT0ZOp7KfG63DY2Tqbve73S9cgHCm4CBqtnYksGsmoCaNpQ7xCYfZXQOU54WxLP2SNgkY5xOkMnNr0gZUJNLDsFlGiKqMeHQRNegNFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783217142; c=relaxed/simple; bh=so+yhVCvvaIqqGt6b6i9YWmP4WE6FyTqPwNSmqlViWM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=txkiBoZWweMIX+xbBBS2uJsveWn203Kt+gWaiU6aqYM7NoHAurAKmj4D0SG8pF1vL5p5iFadNGo/ZaYYJF98jJ9D8SmWZaYe7p7/zsIFhogZR28kebCEKaC/BCfA2XsoCeI8EuvNypV4lioqTvDxvxrz/Qq9tCKqTXJLSvD4+Qs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AKcHy2sw; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AKcHy2sw" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-383b4a3755fso1003248a91.3 for ; Sat, 04 Jul 2026 19:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783217140; x=1783821940; darn=vger.kernel.org; h=content-type:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=HKocKtEz1RsMH+lMlj2oc8msPllSiCeLmatH4dj48Vo=; b=AKcHy2swoiARF6SHujuR2GIVY+7AXxaPUBSkMQTV0HnDzhDTphbn5P3SRivfmFY5ix SIo78aL2e5peyqC1O6ps0SsGj7YHXMPYBlnAn4xhoY08Sjyl/82LC4de78wKqtLxrH9N mCkU7HhU1xY4aYzO/k53u9JYPBsEafFyzisUvgzKJGS7yQeuX+g08Z0ohucoQ367J5TE 0ya0dVUfWGF9NSS7fX4Ezy77AmDg2JmvV8FGEzfB7RTvqBvWZpFYyjrryj3uWdc3BvXU xqQIEqh7tAw3/SRFBHtxs2u/4n91YVW0yXTUiWQuODNjx1qQZFVQs2S9Z8vTCMfAq+wx azTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783217140; x=1783821940; h=content-type:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HKocKtEz1RsMH+lMlj2oc8msPllSiCeLmatH4dj48Vo=; b=nNrO+TT/KGdIb6cCJOK/2G9JYyBCWQvBLEa8N2F3efA9qMIWjq3yCu/v4Kqi/DA9mB 1FcBKqXvZX1/n/O1orlyKzJ/Uh0+/eugcS/sPugsX49Qs0gMcpRwOMKVDwGlWtD9rJ6P lrkxd/00haIMTmdFawH2rcl+h3QqW7mEONbWPmUy7RK9HwytxowhIKxdn2ofHvQNyG8a 6KY/gYt9IPhuY90nayno5PN/O2OFe5KIqXvG71OJoJHxzbO8TQPJz08/yACcD+04Wdd5 UJmgg+nJJb/OD4rflmMrNdVTXlPxNmrVYcmuBGePAuDJ79SK2chcFu7C90+t2YIS8St8 FpxA== X-Forwarded-Encrypted: i=1; AHgh+Rq4cInG1uAbMweK+CjIf6r65sGIDKImJdvSR1NOwuUQ1liQDSgZraM6SornUoMCOPNunaPIUKOlwaaZya0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0MOvukkHJz+lioWz1Bc32FrpMxlPhDRL3lku/bLwEuavCz01t PwLotd6YxZYxrKxFdKIQQfjK5lPE/cyr0Aloa/7Sy+44l6exhQHp0yzD X-Gm-Gg: AfdE7ckd8jzGqg4KpZ18Q50mC20Qamaro0Wfhm8+bIb3H2Femot5mRqhj8oxDTeFKKu efM0DuPuAUKIaAhVcrKCWisndvuVMPecGylE62sdvxA43mvNf4Ev4UUNJdd6MX5OzidskotQut8 9vNcGBwcwWJkVESwAbYvi9m4BRz2pdq3NtyKinKXFdHD5qT2/F4o4tVCMEnIWe9Rlwrkj5xH6R6 up3R+qBkkImNyVBQZ1JT2QN86AioIR9/Hm4gmEbIF52SvQl/OiP5JFUPJ766NrSj1J38qIrBg/N HKXbRAuMdy1Fx8/lDbKmg2YqwEH7nYqvFkI6Hyd7acqJEPjHb47XMNLLrVHPu45Z2mV54TqotNF Pk8p4SlNT0QEzKM7WbsJakD1M4vJt7SrTsUOBMhT1ChvpJgr4GcMCM0fIbY07kl4tpWlarfhhsq TlZZLMllh0/+RMLLh7rj8CVAk9sArYd/e2aNdo0/KTBFK8/S9yfbL8GaYH7iuaSpqC+Ol9HZC00 11FvEJjlcY10ajAbPhJ2E7AmqdyoTd+sBC6Hlu6f55Fb+mTsIpaSpDtfE2eiyrGfo4sAdoqaIrR /i11 X-Received: by 2002:a17:90b:3808:b0:37f:9ce1:cda4 with SMTP id 98e67ed59e1d1-3829f2f3fafmr4872588a91.26.1783217140598; Sat, 04 Jul 2026 19:05:40 -0700 (PDT) Received: from setsuna.localnet ([2403:581e:d87e:0:fc2d:ed31:e80e:412d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f3a9341e0sm27946996eec.12.2026.07.04.19.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 19:05:40 -0700 (PDT) From: James Calligeros To: Martin =?UTF-8?B?UG92acWhZXI=?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Joshua Peisach Cc: asahi@lists.linux.dev, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/7] ASoC: apple: mca: Support FEs being clock consumers Date: Sun, 05 Jul 2026 12:05:33 +1000 Message-ID: In-Reply-To: References: <20260628-apple-audio-redux-v2-0-6328269c9652@gmail.com> <20260628-apple-audio-redux-v2-4-6328269c9652@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Josh, On Monday, 29 June 2026 11:19:27=E2=80=AFpm Australian Eastern Standard Tim= e Joshua=20 Peisach wrote: > On Sun Jun 28, 2026 at 7:42 AM EDT, James Calligeros wrote: > > + writel_relaxed(port + 6 + 1, > > + cl->base + REG_SYNCGEN_MCLK_SEL); >=20 > Where does the "6 + 1" come from, and should it have its own #define? This actually only ever gets set to 0b111 (port =3D 0), and trying to set it to anything else breaks the machines which consume VISENSE data from the connected codecs. I will just replace this with a static value for v3, which seems to work on all the machines we currently support downstream. > -Josh James