The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
Cc: linux-rt-devel@lists.linux.dev, tj@kernel.org,
	hannes@cmpxchg.org, mkoutny@suse.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 08/37] sched/deadline: Do not replenish a boost from cleared parameters
Date: Mon, 16 Nov 2026 19:42:13 +0000	[thread overview]
Message-ID: <sashiko-outbox-217594@kernel.org> (raw)
In-Reply-To: <20261116190549.230119-9-mathieu.desnoyers@efficios.com>

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [Medium] sched/deadline: torn donor parameter reads in
  replenish_dl_entity()
- [Medium] sched/deadline: unreset negative runtime in
  replenish_dl_entity()
- [Medium] sched/deadline: zero deadline in replenish_dl_entity() on
  initial boost
--

commit f55f8a9d26011d4eb967a7bc04c3939d81815727
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

sched/deadline: Do not replenish a boost from cleared parameters

This commit avoids an infinite loop in replenish_dl_entity() when a
boosted entity's donor has left SCHED_DEADLINE and had its parameters
cleared before the priority inheritance chain walk deboosts the owner.

Link: https://lore.kernel.org/all/avL8oOtjKqVNR7-l@jlelli-thinkpadt14gen4.remote.csb/

> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index e4d7cbf4861de..c4ea510599415 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -807,8 +807,26 @@ static void replenish_dl_entity(struct sched_dl_entity *dl_se)
>  {
>  	struct dl_rq *dl_rq = dl_rq_of_se(dl_se);
>  	struct rq *rq = rq_of_dl_rq(dl_rq);
> +	struct sched_dl_entity *pi_se = pi_of(dl_se);
> +	u64 runtime = READ_ONCE(pi_se->dl_runtime);
> +	u64 deadline = READ_ONCE(pi_se->dl_deadline);
> +	u64 period = READ_ONCE(pi_se->dl_period);

[Severity: Medium]
Can replenish_dl_entity() observe a non-zero runtime alongside a zeroed
deadline or period when racing with __dl_clear_params()?

__dl_clear_params() zeroes dl_runtime, dl_deadline and dl_period in that
same order under the donor's rq lock without ordering barriers:

CPU0 (boosted owner)              CPU1 (donor)
replenish_dl_entity()
  runtime = READ_ONCE(pi_se->dl_runtime)
                                  inactive_task_timer()
                                    __dl_clear_params()
                                      dl_se->dl_runtime = 0
                                      dl_se->dl_deadline = 0
                                      dl_se->dl_period = 0
  deadline = READ_ONCE(pi_se->dl_deadline)  <-- reads 0
  period = READ_ONCE(pi_se->dl_period)      <-- reads 0

Because only !runtime is checked below, replenish_dl_entity() proceeds
with runtime > 0 and deadline == 0 or period == 0.  A boosted non-deadline
task gets dl_se->deadline set to rq_clock(rq) + 0, while a boosted
SCHED_DEADLINE task has runtime added in the while (dl_se->runtime <= 0)
loop without advancing dl_se->deadline.  If dl_se->deadline is then in the
past, the lag check emits a false "sched: DL replenish lagged too much"
warning and calls replenish_dl_new_period(), which re-reads
pi_of(dl_se)->dl_deadline and pi_of(dl_se)->dl_runtime directly and sets
dl_se->runtime to 0.

> -	WARN_ON_ONCE(pi_of(dl_se)->dl_runtime <= 0);
> +	/*
> +	 * A boosted entity runs on the parameters of its donor, the top
> +	 * waiter of an rt_mutex. The donor can leave the class and have them
> +	 * cleared before the chain walk deboosts this entity. They are
> +	 * cleared under the donor's rq lock, which can be another one. So
> +	 * read each of them once. Refilling from a runtime of 0 would loop
> +	 * forever. Leave the entity runnable instead: the walk deboosts it,
> +	 * or its task releases the lock.
> +	 */
> +	if (unlikely(!runtime)) {
> +		WARN_ON_ONCE(!is_dl_boosted(dl_se));
> +		dl_se->dl_yielded = 0;
> +		dl_se->dl_throttled = 0;
> +		return;
> +	}

[Severity: Medium]
Does returning here without resetting dl_se->runtime leave the entity with
an accumulating negative runtime?

When a boosted task exhausts its runtime after the donor's parameters are
cleared, dl_se->runtime remains <= 0 across this early return.  Every
subsequent tick in update_curr_dl_se() subtracts delta_exec from
dl_se->runtime, sees dl_runtime_exceeded(dl_se), sets dl_se->dl_overrun
(sending repeated SIGXCPU signals if SCHED_FLAG_DL_OVERRUN is enabled),
and re-enters enqueue_task_dl() -> replenish_dl_entity().

With the follow-up commit "sched/deadline: Reset the donor's runtime at a
deboost in the class", this return also happens before
dl_note_donor_refill(dl_se).  If a SCHED_DEADLINE owner had not been
refilled from the donor before the donor's parameters were cleared,
dl_donor_refill stays 0 and dl_deboost() does not reset dl_se->runtime;
when dl_se->deadline is still in the future at deboost, the negative
runtime is charged against the owner's own periods on its next replenish,
or pushes zerolag_time past dl_se->deadline in task_non_contending() if
the owner blocks first.

[Severity: Medium]
Can this early return also leave dl_se->deadline at 0 when a runnable
non-deadline task is first boosted into SCHED_DEADLINE?

When rt_mutex_setprio() boosts a runnable non-deadline task whose
dl_se->deadline is 0, it sets ENQUEUE_REPLENISH and calls
enqueue_task_dl() -> enqueue_dl_entity() -> replenish_dl_entity().  If the
donor's parameters were already cleared (for example after
normalize_rt_tasks(), or before a multi-hop PI chain walk finishes
deboosting an intermediate lock owner), replenish_dl_entity() returns here
before the dl_se->dl_deadline == 0 branch initializes dl_se->deadline.

__enqueue_dl_entity() then calls inc_dl_deadline() with deadline == 0:

kernel/sched/deadline.c:inc_dl_deadline() {
	if (dl_rq->earliest_dl.curr == 0 ||
	    dl_time_before(deadline, dl_rq->earliest_dl.curr)) {
		if (dl_rq->earliest_dl.curr == 0)
			cpupri_set(&rq->rd->cpupri, rq->cpu, CPUPRI_HIGHER);
		dl_rq->earliest_dl.curr = deadline;
		cpudl_set(&rq->rd->cpudl, rq->cpu, deadline);
	}
}

Because dl_rq->earliest_dl.curr == 0 is the sentinel for an empty dl_rq,
enqueuing a subsequent deadline task with a later deadline overwrites
dl_rq->earliest_dl.curr and cpudl, hiding earlier deadlines on this rq
from cross-CPU deadline balancing.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116190549.230119-1-mathieu.desnoyers@efficios.com?part=8

  reply	other threads:[~2026-11-16 19:42 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 19:05 [PATCH v6 00/37] sched/deadline: bandwidth accounting fixes and selftests Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 01/37] sched: Refuse SCHED_FLAG_KEEP_PARAMS that would change the policy or the class Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 02/37] sched/deadline: Do not admit bandwidth for parameters that are kept Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 03/37] sched: Let a task boosted by a deadline waiter change its policy Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 04/37] sched/deadline: Do not divide by zero active CPUs of a root domain Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 05/37] sched/deadline: Refuse dl_server debugfs writes while the rq is offline Mathieu Desnoyers
2026-11-16 19:30   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 06/37] sched: Take cpuset_mutex for a deadline policy change only with pi Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 07/37] sched/deadline: Do not lose a throttled task switched out and back Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 08/37] sched/deadline: Do not replenish a boost from cleared parameters Mathieu Desnoyers
2026-11-16 19:42   ` sashiko-bot [this message]
2026-11-16 19:05 ` [PATCH v6 09/37] sched/deadline: Reset the deadline and the runtime with the parameters Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 10/37] sched/deadline: Reset the donor's runtime at a deboost in the class Mathieu Desnoyers
2026-11-16 19:38   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 11/37] sched/deadline: Release the bandwidth of a task that leaves the class asleep Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 12/37] sched/deadline: Reject SCHED_DEADLINE on exited tasks Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 13/37] sched/deadline: Keep departing bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 14/37] sched/deadline: Fix this_bw when a task is changed during a remote wakeup Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 15/37] sched/deadline: Rebuild the root domains' accounting from the task list Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 16/37] sched/deadline: Record the root domain holding a task's bandwidth Mathieu Desnoyers
2026-11-16 19:44   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 17/37] sched/deadline: Leave a dying task out of a rebuild of the accounting Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 18/37] sched/deadline: Check SCHED_DEADLINE affinity under the rq lock Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 19/37] sched/deadline: Move a task's bandwidth only where room was made Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 20/37] cgroup/cpuset: Wait for an attach before rebuilding the sched domains Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 21/37] sched: Make deadline policy and affinity changes wait for a cpuset attach Mathieu Desnoyers
2026-11-16 19:31   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 22/37] cgroup/cpuset: Give back the bandwidth an attach did not move Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 23/37] cgroup/cpuset: Reserve the bandwidth in the root domain a task moves to Mathieu Desnoyers
2026-11-16 19:56   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 24/37] sched/deadline: Make a rebuild count a task in the root domain it runs in Mathieu Desnoyers
2026-11-16 20:01   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 25/37] sched/deadline: Move a task's bandwidth to " Mathieu Desnoyers
2026-11-16 19:47   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 26/37] sched/deadline: Keep a task in the root domain that counts its bandwidth Mathieu Desnoyers
2026-11-16 19:50   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 27/37] sched/deadline: Keep the last CPU a task has in its root domain Mathieu Desnoyers
2026-11-16 19:51   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 28/37] cgroup/cpuset: Refuse to take a deadline task out of " Mathieu Desnoyers
2026-11-16 20:08   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 29/37] sched/deadline: Cancel the replenishment timer with the parameters Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 30/37] sched/deadline: Count the bandwidth a boosted task is given Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 31/37] sched/deadline: Start a period for a task that enters the class blocked Mathieu Desnoyers
2026-11-16 20:12   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 32/37] sched/deadline: Check the runtime of a task that comes back runnable Mathieu Desnoyers
2026-11-16 20:08   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 33/37] sched/deadline: Check the runtime of a task whose parameters change Mathieu Desnoyers
2026-11-16 20:04   ` sashiko-bot
2026-11-16 19:05 ` [PATCH v6 34/37] sched/debug: Show the deadline bandwidth of each runqueue Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 35/37] selftests/sched: Add a test of SCHED_DEADLINE policy round trips Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 36/37] selftests/sched: Test SCHED_DEADLINE bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-16 19:05 ` [PATCH v6 37/37] selftests/sched: Add a test of SCHED_DEADLINE bandwidth accounting Mathieu Desnoyers
2026-11-16 19:49   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217594@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mkoutny@suse.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox