From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79A31391E49 for ; Mon, 30 Mar 2026 06:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774853393; cv=none; b=MFEhly9juo6IOwRxfsSgz3e1JKjltskKWOMyo8pmMs/IS9ennPV60z/g7JWbD7jhF/vrusYW4qMJSV8UXzf70ZvTD/tW9GJ7Ta3c7HijTbwvGkPbFeGW1yiy8Wn9KG6JOE2F2kfnLiGfDsfSKF3nlX+U7wxjERxHYXQcGQtgHAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774853393; c=relaxed/simple; bh=IcI+m9ECDKqxJZ8kfZdOCb3RhA/RxC2TWzIlLpOMZRE=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=IeKviyv4jAbZbQiwu+Z28GqMc+2I6DKsVHGVRAZuK+N+bG8Wl9Ap7M2P6S6yNtBrVowxBE9H3J3Qs4l9Nu9tYKjYq0aPlWY8fsO+RjuyWh2t2em5YnJItRYzr/BmvwcLylmaDGmhwKUqT/K5yWtw/WTXNFnWuqhDK08berMlBpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hQf9sBS2; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hQf9sBS2" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c7393c6832bso1263694a12.2 for ; Sun, 29 Mar 2026 23:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774853391; x=1775458191; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=tulUJSN7MABRwEgvUtQdM4fFuvpVGNODzZ+gwA9Y1b8=; b=hQf9sBS2LV29cUnFzTilvTbMfIDi2A3Uv9PaF0UeQp/cfGAz3nAjBznf/0I5qtV5Km W48gfYHJu+zV1SE5opEEaJQ+7/QOTgBQzMCPDDgjLO+pK2QP5mRufISa9ZRQlFAlmI2h e8sQBgDt5yxbF7P5Zuyv5fEBbWyOBvzKvFeC4ujpDenVESvN4+33uBitkBbi7iYMJ6iI VViL3jhjdLSKUCDziMAX/Bi41j3LsXqBm0FgdSUbsHb3uw4lsYGPxh87hEe7CtEIkuGY tcPpvmuVDV7T1h5zgikvxwrWm2Kpnqb6nyCG5SchwmyaPpS3Z+YWE/a6iUw9PVJ5+euR bQzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774853391; x=1775458191; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tulUJSN7MABRwEgvUtQdM4fFuvpVGNODzZ+gwA9Y1b8=; b=pX+04vTuLiLTC+jhyYgE6D9pNJ3gHeFZPR+h4R6g33I8ggKqXEgHsK3pGJDJhnBGtt 72OK5OeI69ZQBxztNNfYEy9TAlx4UmFHaP2AeHCSH+PmfYf+WCrxkuGe051aqjriar3O MVmMWHG8O7VYE4LpJ3mOrN3IRCWNkizugDxhGwVMCNZ/CsYMotWDnQdJteR5hHehONOr RGkltbkTtFY6A0FxB8UkvvScVjq1N0ov+HCcDli3teHjzejAzpUDzoM6UtQDBZGXcjnP YeIf+udNvXGzs+pioytXPHrWWGKm7eprlPgtbvM2oHBnPjFXqAgRYvn5r9+gZcH8qMDE +gBw== X-Forwarded-Encrypted: i=1; AJvYcCWlNBQacykfhMS5UkQwe0oTgN9LW5geS1ljTP96d2XJFLWkXZ3zVXZrRIBznKB2NmTlJdrR2pOQfCG3yLU=@vger.kernel.org X-Gm-Message-State: AOJu0YwcHfPeO6XWqieOX0nC2SLWz52XDsDy2bChqNoLubGMQKImrWhy gGs5gm+5cFDfiu1PyNgqsD55VQ2QHw/GUMdp+wNX/pkvQjiq4hp8yjp0 X-Gm-Gg: ATEYQzzRMgnBR+RJGNGiZCm8DE7bm4u9EGZ+V6LWTcGMlirP/vyPMl0npldWcG3Ivu4 wYwBSqZsbesww1t09z443r1kns/VV0wSpPA0ZPA6Y5aRCgpbaK+Dbjh9CXurN0QWgHfnqYYcezx pNNVMCLrvuwn/A3tD6Hfe0m1LvakehXjAzW1mggRCdzu/yL+1Sy+KejU/MQof/7/TaXNKPDhG69 sxm+2up1cIKPtjbyr/j3rS1q5prqODo2l7eENjwnZb15TBBKGKUiSwW3TbFPjrDBXRgGymih0Or XeXOxoaIvZArv4ta7IYl+zN4n+6+jBe85SxTlU1FEYZfu2aBd06RHxheiLkNmti2VwzHPwiOOs2 IykbKDeFKMEm0O6It7dKqS9QZZ4CzK75WzS7gAABNFflqsTFKx0DXU/nZEKQkzdRekhT8F4MD9/ SQx4gN8HD5eF+WIPhzqOLggA== X-Received: by 2002:a17:90b:35cc:b0:35c:29ba:bf92 with SMTP id 98e67ed59e1d1-35c2ffa8af9mr10929498a91.5.1774853390700; Sun, 29 Mar 2026 23:49:50 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c22d8c500sm11522842a91.10.2026.03.29.23.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 23:49:50 -0700 (PDT) From: Ritesh Harjani (IBM) To: Venkat Rao Bagalkote , linux-kernel@vger.kernel.org Cc: linux-kbuild@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com, arnd@arndb.de, chleroy@kernel.org, Venkat Rao Bagalkote Subject: Re: [PATCH v3] char: nvram: Remove unused nvram_mutex to fix -Wunused-variable warning In-Reply-To: <20260330062201.2581-1-venkat88@linux.ibm.com> Date: Mon, 30 Mar 2026 12:12:28 +0530 Message-ID: References: <20260330062201.2581-1-venkat88@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Venkat Rao Bagalkote writes: > drivers/char/nvram.c defines a static mutex 'nvram_mutex' which is never > used. This results in a compiler warning on linux-next builds: > > warning: 'nvram_mutex' defined but not used [-Wunused-variable] > > Remove the unused definition to avoid the warning. > That is not the only reason for removing the nvram_mutex. I think we discussed in detail, why we think this can be removed here [1]. We should add those details in commit msg too. > Suggested-by: Arnd Bergmann > Suggested-by: Ritesh Harjani (IBM) > Signed-off-by: Venkat Rao Bagalkote > --- > v3: > - Removed global nvram_mutex entirely We only removed the mutex definition and not the usage right. This does not look correct. Maybe you can check sashiko review comments for details - https://sashiko.dev/#/patchset/20260330062201.2581-1-venkat88%40linux.ibm.com -ritesh > > drivers/char/nvram.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/char/nvram.c b/drivers/char/nvram.c > index 9eff426a9286..9ab2744cd375 100644 > --- a/drivers/char/nvram.c > +++ b/drivers/char/nvram.c > @@ -53,7 +53,6 @@ > #include > #endif > > -static DEFINE_MUTEX(nvram_mutex); > static DEFINE_SPINLOCK(nvram_state_lock); > static int nvram_open_cnt; /* #times opened */ > static int nvram_open_mode; /* special open modes */ > -- > 2.45.2