public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	Andrew Morton <akpm@osdl.org>,
	kuznet@ms2.inr.ac.ru, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Allow either tid or pid in SCM_CREDENTIALS struct ucred
Date: 22 Aug 2003 11:02:18 -0700	[thread overview]
Message-ID: <shs4r094llh.fsf@charged.uio.no> (raw)
In-Reply-To: <3F464CE4.8040704@redhat.com>

>>>>> " " == Ulrich Drepper <drepper@redhat.com> writes:

     > I don't think ->pid should be tested.  Just replace it with
     > ->tgid.  It's really not intended for the user to have any
     > contact with the TID (i.e., ->pid).  This is how it's done in
     > other place.  What this shows is that more searches for ->pid
     > are needed which need to be replaced with ->tgid.

There's one remaining case in the NFS locking code:
nlmclnt_setlockargs() is using ->pid in order to label the lock owner.

I have a feeling that for that particular case, we'll just want to
drop the entire process-crap. The reason is that spec just says

   "The oh field is an opaque object that identifies the host or
   process that is making the request."

So as long as we're doing the lock accounting correctly on the client,
the server should be happy with just the hostname.
AFAIK, the word 'process' in the above sentence was added mainly in
order to allow userland NFS clients to push the accounting over onto
the server.

Cheers,
  Trond

      reply	other threads:[~2003-08-22 18:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-21  7:39 [PATCH] Allow either tid or pid in SCM_CREDENTIALS struct ucred Jeremy Fitzhardinge
2003-08-22 17:03 ` Ulrich Drepper
2003-08-22 18:02   ` Trond Myklebust [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=shs4r094llh.fsf@charged.uio.no \
    --to=trond.myklebust@fys.uio.no \
    --cc=akpm@osdl.org \
    --cc=drepper@redhat.com \
    --cc=jeremy@goop.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox