From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Ian Grant <Ian.Grant@cl.cam.ac.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.10 build failure - atomic_dec_and_lock export
Date: 02 Oct 2001 18:19:21 +0200 [thread overview]
Message-ID: <shs669yvwty.fsf@charged.uio.no> (raw)
In-Reply-To: <E15oRJg-00005z-00@wisbech.cl.cam.ac.uk>
In-Reply-To: Ian Grant's message of "Tue, 02 Oct 2001 16:18:40 +0100"
>>>>> " " == Ian Grant <Ian.Grant@cl.cam.ac.uk> writes:
> Trond,
> 2.4.10 won't link with CONFIG_SMP and i386 CPU selected. I
> believe the problem
> lies in in the #ifndef atomic_dec_and_lock in
> lib/dec_and_lock.c. As far as I can see this symbol is always
> defined because it's exported.
This patch looks very redundant.
If you have CONFIG_SMP defined then atomic_dec_and_lock will never get
defined, and if CONFIG_HAVE_DEC_LOCK is not defined, then
dec_and_lock.c will never even get compiled. Even the config.h include
is superfluous as linux/module.h will include it.
I don't understand though: I have no problems compiling and linking
stock 2.4.10 with CONFIG_M386=y + CONFIG_SMP=y.
Are you sure that you didn't miss a 'make dep' after doing 'make
config'/'make oldconfig'?
Cheers,
Trond
PS: sorry that you received this mail twice Ian. I didn't notice the
first time around that you had Cced the l-k list.
next prev parent reply other threads:[~2001-10-02 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-02 15:18 2.4.10 build failure - atomic_dec_and_lock export Ian Grant
2001-10-02 16:19 ` Trond Myklebust [this message]
2001-10-02 16:39 ` Andreas Schwab
2001-10-02 17:52 ` Trond Myklebust
2001-10-03 2:52 ` [patch] " Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shs669yvwty.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=Ian.Grant@cl.cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox