From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Manfred Spraul <manfred@colorfullife.com>,
Andrea Arcangeli <andrea@suse.de>, Hubert Mantel <mantel@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: Compatibility issue with 2.2.19pre7
Date: 11 Jan 2001 19:22:03 +0100 [thread overview]
Message-ID: <shsae8y2blg.fsf@charged.uio.no> (raw)
In-Reply-To: <20010110013755.D13955@suse.de> <200101100654.f0A6sjJ02453@flint.arm.linux.org.uk> <20010110163158.F19503@athlon.random> <shszogy2jmr.fsf@charged.uio.no> <3A5DDD09.C8C70D36@colorfullife.com> <14941.61668.697523.866481@charged.uio.no>
In-Reply-To: Trond Myklebust's message of "Thu, 11 Jan 2001 18:44:04 +0100 (CET)"
>>>>> " " == Trond Myklebust <trond.myklebust@fys.uio.no> writes:
> - if (file->f_handle.fh_dcookie == fh->fh_dcookie &&
> - !memcmp(&file->f_handle, fh, sizeof(*fh)))
> + if (file->f_handle.fh_dcookie == fh.fh_dcookie &&
> + !memcmp(&file->f_handle, &fh, sizeof(fh)))
> goto found;
Come to think of it, this line looks pretty insane. Why on earth are
we testing fh_dcookie twice?
I suspect that just the elimination of the redundant comparison in the
above line would eliminate Russell's problem entirely, given that it's
the only place in the entire routine where we actually reference
fh->fh_base.fb_dentry.
In all other cases, we're referencing ordinary integers. Are there any
alignment requirements on them?
Cheers,
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-11 18:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-10 0:37 Compatibility issue with 2.2.19pre7 Hubert Mantel
2001-01-10 0:43 ` Alan Cox
2001-01-10 6:54 ` Russell King
2001-01-10 15:31 ` Andrea Arcangeli
2001-01-10 22:09 ` Russell King
2001-01-10 23:59 ` Andrea Arcangeli
2001-01-11 7:34 ` Russell King
2001-01-11 10:33 ` Andi Kleen
2001-01-11 10:36 ` Russell King
2001-01-11 12:10 ` Manfred
2001-01-11 12:10 ` Andi Kleen
2001-01-11 12:29 ` Manfred
2001-01-11 13:27 ` Russell King
2001-01-24 7:51 ` Richard Henderson
2001-01-24 9:02 ` Andrea Arcangeli
2001-01-24 9:51 ` Richard Henderson
2001-01-24 12:21 ` Andrea Arcangeli
2001-01-24 17:49 ` Richard Henderson
2001-01-24 10:09 ` Thomas Pornin
2001-01-11 15:28 ` Trond Myklebust
2001-01-11 16:19 ` Manfred Spraul
2001-01-11 17:44 ` Trond Myklebust
2001-01-11 18:22 ` Trond Myklebust [this message]
2001-01-11 18:27 ` Andrea Arcangeli
2001-01-11 18:30 ` Trond Myklebust
2001-01-11 18:43 ` Andrea Arcangeli
2001-01-11 20:09 ` Russell King
2001-01-11 20:39 ` Trond Myklebust
2001-01-11 11:37 ` Trond Myklebust
-- strict thread matches above, loose matches on Subject: below --
2001-01-24 13:46 Jesse Pollard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shsae8y2blg.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mantel@suse.de \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox