From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: carlos@fisica.ufpr.br (Carlos Carvalho), linux-kernel@vger.kernel.org
Subject: Re: 2.2.19pre10 doesn't compile on alphas (sunrpc)
Date: 13 Feb 2001 10:56:28 +0100 [thread overview]
Message-ID: <shslmra9a9f.fsf@charged.uio.no> (raw)
In-Reply-To: <E14SQqi-0008Bm-00@the-village.bc.nu>
In-Reply-To: Alan Cox's message of "Mon, 12 Feb 2001 21:49:29 +0000 (GMT)"
>>>>> " " == Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
>> net/network.a(sunrpc.o): In function `xprt_ping_reserve':
>> sunrpc.o(.text+0x4b94): undefined reference to `BUG'
>> sunrpc.o(.text+0x4b98): undefined reference to `BUG'
>>
>> Looks like a problem in Trond's patches, also it doesn't happen
>> with pre9. It links in intel machines. I didn't reboot to test
>> yet...
> The ideal solution would be for someone to provide BUG() on the
> Alpha platform as in 2.4. That would sort things cleanly
Actually, since BUG() only seems to be defined on i386 platforms for
2.2.x, perhaps the easiest thing to do (unless somebody wants to
volunteer to backport all the `safe' definitions from 2.4.x) would be
to add the generic `*(int *)0 = 0' definition for local use by ping()
itself.
Cheers,
Trond
--- net/sunrpc/ping.c.orig Tue Feb 13 10:47:20 2001
+++ net/sunrpc/ping.c Tue Feb 13 10:50:03 2001
@@ -25,6 +25,10 @@
# define RPCDBG_FACILITY RPCDBG_XPRT
#endif
+#ifndef BUG
+#define BUG() do { printk("kernel BUG at %s:%d!\n", __FILE__, __LINE__); *(int *)0=0; } while (0)
+#endif
+
static void ping_call_reserve(struct rpc_task *);
static void ping_call_allocate(struct rpc_task *);
static void ping_call_encode(struct rpc_task *);
next prev parent reply other threads:[~2001-02-13 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-12 20:23 2.2.19pre10 doesn't compile on alphas (sunrpc) Carlos Carvalho
2001-02-12 21:49 ` Alan Cox
2001-02-12 22:08 ` Carlos Carvalho
2001-02-12 22:11 ` Alan Cox
2001-02-12 22:33 ` David S. Miller
2001-02-14 2:30 ` Richard Henderson
2001-02-13 9:56 ` Trond Myklebust [this message]
2001-02-13 10:16 ` Carlos Carvalho
2001-02-13 10:33 ` Carlos Carvalho
2001-02-13 11:22 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shslmra9a9f.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=carlos@fisica.ufpr.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox