Re: [NFS] [PATCH] Bug in NFS - should umask be allowed to set umask???

[Trond Myklebust <trond.myklebust@fys.uio.no>]

>>>>> " " == Alan Cox <alan@redhat.com> writes:

    >> 1/ Claim that redhat is broken. Leave them to fix SysVinit.  2/
    >> Have nfsd over-write the umask setting that /sbin/init imposed.
    >> This is effectively what your patch does.  3/ Decide that it is
    >> inappropriate for nfsd to share the current->fs fs_struct with
    >> init.  Unfortunately this means changing or replacing
    >> daemonize().

     > #3 seems right. Of course its not clear whose fs struct should
     > #be shared

Well, you can either use the fs_struct from init, or that of the first
process to call nfsd. I'm not sure if there's any real point in having
a chrooted nfsd, but it's easy to implement.

In either case, the principle is the same: use copy_fs_struct() on
whatever you want to clone, then have all the nfsd daemons and the
lockd daemon attach to the new shared fs_struct when they get set up.
No need to replace daemonize...

Cheers,
  Trond