From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Andrew Morton <akpm@digeo.com>
Cc: viro@parcelfarce.linux.theplanet.co.uk, torvalds@transmeta.com,
Andries.Brouwer@cwi.nl, linux-kernel@vger.kernel.org
Subject: Re: [patch?] truncate and timestamps
Date: 23 May 2003 07:11:33 +0200 [thread overview]
Message-ID: <shsvfw29ri2.fsf@charged.uio.no> (raw)
In-Reply-To: <20030522194211.4191e473.akpm@digeo.com>
>>>>> " " == Andrew Morton <akpm@digeo.com> writes:
> I assume every foo_truncate() is doing
inode-> i_mtime = inode->i_ctime = CURRENT_TIME;
> mark_inode_dirty(inode);
> and as Andries says, we can probably pull all that up to the
> VFS level.
No. Please do not assume that the above is equivalent to calling
notify_change() with ATTR_MTIME|ATTR_CTIME.
NFS tends to leave the above to the server side, since the clocks may
be desynchronized between client and server.
As far as NFS is concerned, we should only be setting ATTR_*TIME if/when
the *user* specifies it through a utimes() call or something like that.
Cheers,
Trond
next prev parent reply other threads:[~2003-05-23 4:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-23 0:17 [patch?] truncate and timestamps Andries.Brouwer
2003-05-23 0:30 ` Linus Torvalds
2003-05-23 1:17 ` viro
2003-05-23 2:42 ` Andrew Morton
2003-05-23 5:11 ` Trond Myklebust [this message]
2003-05-23 5:25 ` Trond Myklebust
2003-05-23 3:14 ` David Schwartz
2003-05-26 23:42 ` Alan Cox
2003-05-27 1:17 ` Andrew Morton
2003-05-23 18:02 ` Kai Henningsen
2003-05-23 19:07 ` Andries Brouwer
-- strict thread matches above, loose matches on Subject: below --
2003-05-22 19:09 Andries.Brouwer
2003-05-22 23:20 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shsvfw29ri2.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=Andries.Brouwer@cwi.nl \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox