public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Derek Atkins <derek@ihtfp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kostadin Karaivanov <larry@minfin.bg>, linux-kernel@vger.kernel.org
Subject: Re: ipsec-tools 0.1 + kernel 2.5.64
Date: 05 Mar 2003 13:43:30 -0500	[thread overview]
Message-ID: <sjmbs0pvelp.fsf@kikki.mit.edu> (raw)
In-Reply-To: <20030305182715.A27888@infradead.org>

Christoph Hellwig <hch@infradead.org> writes:

> It's new in glibc 2.3

Ahh.. Thanks.  I'm still using older versions myself.

> #ifdef <OS> is a very bad style.  As you're already using autoconf
> I'd suggest just checking for HAVE_GETIFADDRS

Well, the problem is that the replacement function is only valid on
Linux, so I need to have the <OS> test in there anyways.  It may be
"bad style", but the test needs to exist _somewhere_.  Besides, I've
never been one to be convinced to do something purely based on
stylistic arguments.  Give me a real technical reason why it needs to
be different and I'll consider changing it.

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord@MIT.EDU                        PGP key available

  reply	other threads:[~2003-03-05 18:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-05 18:15 ipsec-tools 0.1 + kernel 2.5.64 Derek Atkins
2003-03-05 18:27 ` Christoph Hellwig
2003-03-05 18:43   ` Derek Atkins [this message]
2003-03-05 18:51     ` Christoph Hellwig
2003-03-05 19:00       ` Derek Atkins
2003-03-05 19:55       ` Derek Atkins
  -- strict thread matches above, loose matches on Subject: below --
2003-03-05 11:49 Kostadin Karaivanov
2003-03-05 16:05 ` Kostadin Karaivanov
2003-03-05 11:29 Andreas Jellinghaus
2003-03-05 11:28 ` bert hubert
2003-03-05 14:52   ` Derek Atkins
2003-03-05 12:47 ` James Morris
2003-03-05 19:33   ` Andreas Jellinghaus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sjmbs0pvelp.fsf@kikki.mit.edu \
    --to=derek@ihtfp.com \
    --cc=hch@infradead.org \
    --cc=larry@minfin.bg \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox