bttv compile failure in 2.5.8-pre2

bttv compile failure in 2.5.8-pre2

[Richard Gooch]

  Hi, all. Compiling 2.5.8-pre2, I got the following:

bttv-driver.c:2650: `video_generic_ioctl' undeclared here (not in a function)
bttv-driver.c:2650: initializer element is not constant
bttv-driver.c:2650: (near initialization for `bttv_fops.ioctl')
bttv-driver.c:2655: initializer element is not constant
bttv-driver.c:2655: (near initialization for `bttv_fops')
bttv-driver.c:2664: unknown field `kernel_ioctl' specified in initializer
bttv-driver.c:2771: `video_generic_ioctl' undeclared here (not in a function)
bttv-driver.c:2771: initializer element is not constant
bttv-driver.c:2771: (near initialization for `radio_fops.ioctl')
bttv-driver.c:2773: initializer element is not constant
bttv-driver.c:2773: (near initialization for `radio_fops')
bttv-driver.c:2781: unknown field `kernel_ioctl' specified in initializer
make[3]: *** [bttv-driver.o] Error 1

				Regards,

					Richard....
Permanent: rgooch@atnf.csiro.au
Current:   rgooch@ras.ucalgary.ca

Re: bttv compile failure in 2.5.8-pre2

[Gerd Knorr]

Richard Gooch wrote:
>    Hi, all. Compiling 2.5.8-pre2, I got the following:
>  
>  bttv-driver.c:2650: `video_generic_ioctl' undeclared here (not in a function)

The same is true for nearly all other v4l drivers.  Dave picked up my
videodev patch from the list and feeded it to Linus, but all the related
driver fixes are not in the kernel yet ...

2.4.7 patches are at http://bytesex.org/patches/2.5/
I'll rediff against -pre2 and resend stuff next days ...

  Gerd

-- 
#include </dev/tty>

Re: bttv compile failure in 2.5.8-pre2

[Thierry Vignaud]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

Gerd Knorr <kraxel@bytesex.org> writes:

> The same is true for nearly all other v4l drivers.  Dave picked up
> my videodev patch from the list and feeded it to Linus, but all the
> related driver fixes are not in the kernel yet ...
>
> 2.4.7 patches are at http://bytesex.org/patches/2.5/
> I'll rediff against -pre2 and resend stuff next days ...

bttv-0.8.x also needs this fix since pointers to __devexit functions
should be marked __devexit_p so that newer binutils don't cry about
references to discarded symbols :


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: in core kernel bttv build fix --]
[-- Type: text/x-patch, Size: 362 bytes --]

--- drivers/media/video/bttv-driver.c.orig	Thu Apr  4 02:12:59 2002
+++ drivers/media/video/bttv-driver.c	Fri Apr  5 06:12:53 2002
@@ -3394,7 +3394,7 @@
         name:     "bttv",
         id_table: bttv_pci_tbl,
         probe:    bttv_probe,
-        remove:   bttv_remove,
+        remove:   __devexit_p(bttv_remove),
 };
 
 static int bttv_init_module(void)

[-- Attachment #3: Type: text/plain, Size: 49 bytes --]


-- 
Still untested beyond 'it compiles' (davej)