From: Oleg Verych <olecom@flower.upol.cz>
To: linux-kernel@vger.kernel.org
Subject: Re: [RFC 6/7] Use an external declaration in exit.c for fs_cachep
Date: Sat, 18 Nov 2006 06:37:19 +0000 (UTC) [thread overview]
Message-ID: <slrneltauh.dd3.olecom@flower.upol.cz> (raw)
In-Reply-To: 20061118173253.85d5b7e8.sfr@canb.auug.org.au
On 2006-11-18, Stephen Rothwell wrote:
[]
>> --- linux-2.6.19-rc5-mm2.orig/kernel/exit.c 2006-11-15 16:48:11.485511089 -0600
>> +++ linux-2.6.19-rc5-mm2/kernel/exit.c 2006-11-17 23:04:09.764530373 -0600
>> @@ -48,6 +48,8 @@
>> #include <asm/pgtable.h>
>> #include <asm/mmu_context.h>
>>
>> +extern kmem_cache_t *fs_cachep;
>
> You know what I am going to say, right? :-)
I know, externs must be in headers. Please, explain why.
TIA.
____
next prev parent reply other threads:[~2006-11-18 6:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-18 5:43 [RFC 0/7] Remove slab cache declarations in slab.h Christoph Lameter
2006-11-18 5:43 ` [RFC 1/7] Remove declaration of sighand_cachep from slab.h Christoph Lameter
2006-11-18 6:27 ` Stephen Rothwell
2006-11-18 6:51 ` SCSI init discussion/SAN problem Evan Rempel
2006-11-20 16:20 ` [RFC 1/7] Remove declaration of sighand_cachep from slab.h Christoph Lameter
2006-11-21 8:07 ` Andrew Morton
2006-11-21 19:36 ` Christoph Lameter
2006-11-21 19:49 ` Andrew Morton
2006-11-21 19:56 ` Christoph Lameter
2006-11-21 20:07 ` Andrew Morton
2006-11-18 5:43 ` [RFC 2/7] Remove bio_cachep " Christoph Lameter
2006-11-18 5:43 ` [RFC 3/7] Move vm_area_cachep to mm.h Christoph Lameter
2006-11-18 5:44 ` [RFC 4/7] Move files_cachep to file.h Christoph Lameter
2006-11-21 8:09 ` Andrew Morton
2006-11-18 5:44 ` [RFC 5/7] Use external declaration for filep_cachep Christoph Lameter
2006-11-18 6:31 ` Stephen Rothwell
2006-11-20 16:20 ` Christoph Lameter
2006-11-18 5:44 ` [RFC 6/7] Use an external declaration in exit.c for fs_cachep Christoph Lameter
2006-11-18 6:32 ` Stephen Rothwell
2006-11-18 6:37 ` Oleg Verych [this message]
2006-11-18 6:53 ` Stephen Rothwell
2006-11-20 16:21 ` Christoph Lameter
2006-11-18 5:44 ` [RFC 7/7] Move names_cachep to fs.h Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=slrneltauh.dd3.olecom@flower.upol.cz \
--to=olecom@flower.upol.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox