public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Verych <olecom@flower.upol.cz>
To: linux-kernel@vger.kernel.org
Subject: Re: Coding style on function signatures  (was: Convert tasklets to work queues )
Date: Sun, 8 Jul 2007 06:02:26 +0000 (UTC)	[thread overview]
Message-ID: <slrnf91089.bju.olecom@flower.upol.cz> (raw)
In-Reply-To: 20070707213753.7480ccca.rdunlap@xenotime.net

>> static ssize_t
>> store_fan_div (struct device *dev, struct device_attribute *devattr,
>>                     const char *buf, size_t count)
>> {...}
>> 
>> 
>> IIRC, many like the entire sig on one line, because its grep friendly.
>> I personally like the above, but grep-ability is hard to argue against.
>
> (I expect that "you" above means Linus, but anyway...)
>
> Some people like the above so that the function name can be grepped
> using a "^store_fan_div" regex, but that's not good enough reason
> for it for others, including Linus, IIRC.

Right. I was reading some LKML archives, and what i know, that returning
type of the function is the first thing Linus cared about.

Newbies homework to think why (and care more about such things and not
of the look).

--
-o--=O`C
 #oo'L O
<___=E M


  reply	other threads:[~2007-07-08  6:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-22 18:20 [RFC PATCH 0/5 v2] Convert all tasklets to workqueues V2 Steven Rostedt
2007-06-22 18:20 ` [RFC PATCH 1/5 v2] Convert the RCU tasklet into a softirq Steven Rostedt
2007-06-22 22:53   ` Paul E. McKenney
2007-06-22 18:20 ` [RFC PATCH 2/5 v2] Split out tasklets from softirq.c Steven Rostedt
2007-06-22 18:20 ` [RFC PATCH 3/5 v2] Add a tasklet is-scheduled API Steven Rostedt
2007-06-22 18:20 ` [RFC PATCH 4/5 v2] Make DRM use the tasklet is-sched API Steven Rostedt
2007-06-22 18:20 ` [RFC PATCH 5/5 v2] Convert tasklets to work queues Steven Rostedt
2007-06-23 16:53   ` Andrew Morton
2007-06-23 18:00     ` Steven Rostedt
2007-06-23 18:19     ` Linus Torvalds
2007-06-23 18:52       ` Randy Dunlap
2007-06-23 18:58         ` Andrew Morton
2007-06-23 19:18         ` Linus Torvalds
2007-07-08  0:49           ` Coding style on function signatures (was: Convert tasklets to work queues ) Jim Cromie
2007-07-08  4:37             ` Randy Dunlap
2007-07-08  6:02               ` Oleg Verych [this message]
2007-07-08 10:12             ` Jan Engelhardt
2007-06-23 19:27       ` [RFC PATCH 5/5 v2] Convert tasklets to work queues Steven Rostedt
2007-06-23 19:39         ` Andrew Morton
2007-06-23 22:09         ` Linus Torvalds
2007-06-28  6:57       ` Jeff Garzik
2007-06-23 17:17   ` Oleg Nesterov
2007-06-23 21:15 ` [RFC PATCH 0/5 v2] Convert all tasklets to workqueues V2 Ed Tomlinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=slrnf91089.bju.olecom@flower.upol.cz \
    --to=olecom@flower.upol.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox