Re: [Bug #14943] nfs regression?

Nikola Ciprich
2010-03-08T20:21:26Z

YES!
seems like 2.6.32.8 with your patch included finally doesn't
spit any backtraces and peername failed errors!
will You push this upstream + to stable?
thanks a lot for Your help!
have a nice day
with best regards
nik

> This seems that we missed checking XPT_DEAD too.
>
> Nikola, does adding !test_bit(XPT_DEAD, &xprt->xpt_flags) in the same
> place as commit b292cf9ce70d221c3f04f help?
>
> Something like:
>
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index 7d1f9e9..7b66c7f 100644
> --- a/net/sunrpc/svc_xprt.c
> +++ b/net/sunrpc/svc_xprt.c
> @@ -700,7 +700,8 @@ int svc_recv(struct svc_rqst *rqstp, long timeout)
>
> len = 0;
> if (test_bit(XPT_LISTENER, &xprt->xpt_flags) &&
> - !test_bit(XPT_CLOSE, &xprt->xpt_flags)) {
> + !test_bit(XPT_CLOSE, &xprt->xpt_flags) &&
> + !test_bit(XPT_DEAD, &xprt->xpt_flags)) {
> struct svc_xprt *newxpt;
> newxpt = xprt->xpt_ops->xpo_accept(xprt);
> if (newxpt) {
>

--
-------------------------------------
Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.: +420 596 603 142
fax: +420 596 621 273
mobil: +420 777 093 799

www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------