The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: 关文涛 <guanwentao@uniontech.com>
To: "WANG Xuerui" <kernel@xen0n.name>, 王昱力 <wangyuli@uniontech.com>,
	davem <davem@davemloft.net>, chenhuacai <chenhuacai@kernel.org>
Cc: linux-crypto <linux-crypto@vger.kernel.org>,
	loongarch <loongarch@lists.linux.dev>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] loongarch/crypto: Clean up useless assignment operations
Date: Tue, 27 Feb 2024 08:44:52 +0000	[thread overview]
Message-ID: <tencent_1407D9AC6F6B4411233FEAD6@qq.com> (raw)
In-Reply-To: <48fd3c4d-9b72-4515-9a95-d241857915b4@xen0n.name>

Okay, somehow i think Yuli the origin commit message some misleading
things,the whole story expand that origin mips/crypto/crc32-mips.c code 
"len -= sizeof(u32);" necessary only in "!CONFIG_64BIT" macro define,
they are just a "binary bit" game as we tran the number to binary bit,
while less and less one in 64bit ,the less thing we do if >=32bit do once,
>=16bit do once ... etc... If we delete the useless code line, it is very cool,
and unrelated to specific ISA. We also think maybe we need to add 
"#ifnef CONFIG_64BIT"in origin mips/crypto/crc32-mips.c "len -= sizeof(u32);",
but it add code instead of delete code...

Thanks.
Guan Wentao

  reply	other threads:[~2024-02-27  8:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26  8:03 [PATCH] loongarch/crypto: Clean up useless assignment operations WangYuli
2024-02-26  8:15 ` WANG Xuerui
2024-02-26  8:25   ` 关文涛
2024-02-27  7:42     ` WANG Xuerui
2024-02-27  9:22       ` Xi Ruoyao
2024-02-27  7:52   ` WANG Xuerui
2024-02-27  8:44     ` 关文涛 [this message]
2024-02-27  9:14       ` 王昱力
2024-02-29  3:05 ` Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_1407D9AC6F6B4411233FEAD6@qq.com \
    --to=guanwentao@uniontech.com \
    --cc=chenhuacai@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kernel@xen0n.name \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=wangyuli@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox