From: jiping huang <huangjiping95@qq.com>
To: vladimir.zapolskiy@linaro.org
Cc: huangjiping95@qq.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, mturquette@baylibre.com,
sboyd@kernel.org
Subject: Re: [PATCH] clk: Delete redundant logic.
Date: Mon, 26 Aug 2024 22:45:25 +0800 [thread overview]
Message-ID: <tencent_728616623FAC3980B7FD8B7FC2F049031208@qq.com> (raw)
In-Reply-To: <6cb9d478-ce85-4b07-82be-a5f517654a78@linaro.org>
I'm very sorry, my submitted description may not have expressed it clearly.
Actually, it is, the local variable 'best_crent_rate' is only used in line 2355 \
for the judgment 'best_crent_rate!=parent ->rate'. However, if the \
"if (clk_core_can_round (core))" branch condition in line 2306 is true, \
the value of the local variable "best_crent_rate" will be updated by \
"best_crent_rate=req.best_crent_rate;" in line 2319, otherwise it will \
be directly returned in the "else if" branch in line 2325 and the "else" branch \
in line 2329.
In summary, it is unnecessary to store the "parent ->rate" value in "best_crent_rate" in line 2301.
next prev parent reply other threads:[~2024-08-26 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 8:29 [PATCH] clk: Delete redundant logic jiping huang
2024-08-26 9:40 ` Vladimir Zapolskiy
2024-08-26 14:45 ` jiping huang [this message]
2024-08-27 10:37 ` kernel test robot
2024-08-29 9:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_728616623FAC3980B7FD8B7FC2F049031208@qq.com \
--to=huangjiping95@qq.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox