From: tip-bot for Sebastian Panceac <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, hpa@zytor.com, sebastian@resin.io,
linux-kernel@vger.kernel.org, mingo@kernel.org,
andy.shevchenko@gmail.com
Subject: [tip:x86/urgent] x86/platform/intel-mid: Handle Intel Edison reboot correctly
Date: Wed, 28 Feb 2018 09:21:59 -0800 [thread overview]
Message-ID: <tip-028091f82eefd5e84f81cef81a7673016ecbe78b@git.kernel.org> (raw)
In-Reply-To: <1519810849-15131-1-git-send-email-sebastian@resin.io>
Commit-ID: 028091f82eefd5e84f81cef81a7673016ecbe78b
Gitweb: https://git.kernel.org/tip/028091f82eefd5e84f81cef81a7673016ecbe78b
Author: Sebastian Panceac <sebastian@resin.io>
AuthorDate: Wed, 28 Feb 2018 11:40:49 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 28 Feb 2018 18:17:18 +0100
x86/platform/intel-mid: Handle Intel Edison reboot correctly
When the Intel Edison module is powered with 3.3V, the reboot command makes
the module stuck. If the module is powered at a greater voltage, like 4.4V
(as the Edison Mini Breakout board does), reboot works OK.
The official Intel Edison BSP sends the IPCMSG_COLD_RESET message to the
SCU by default. The IPCMSG_COLD_BOOT which is used by the upstream kernel
is only sent when explicitely selected on the kernel command line.
Use IPCMSG_COLD_RESET unconditionally which makes reboot work independent
of the power supply voltage.
[ tglx: Massaged changelog ]
Fixes: bda7b072de99 ("x86/platform/intel-mid: Implement power off sequence")
Signed-off-by: Sebastian Panceac <sebastian@resin.io>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/1519810849-15131-1-git-send-email-sebastian@resin.io
---
arch/x86/platform/intel-mid/intel-mid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/intel-mid/intel-mid.c b/arch/x86/platform/intel-mid/intel-mid.c
index 2c67bae6bb53..fb1df9488e98 100644
--- a/arch/x86/platform/intel-mid/intel-mid.c
+++ b/arch/x86/platform/intel-mid/intel-mid.c
@@ -79,7 +79,7 @@ static void intel_mid_power_off(void)
static void intel_mid_reboot(void)
{
- intel_scu_ipc_simple_command(IPCMSG_COLD_BOOT, 0);
+ intel_scu_ipc_simple_command(IPCMSG_COLD_RESET, 0);
}
static unsigned long __init intel_mid_calibrate_tsc(void)
prev parent reply other threads:[~2018-02-28 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANoH8WgoPbhh+OS-HQD5uk3xbedrqHnwufJ9Bj4hSEuuTBkapw@mail.gmail.com>
2018-02-22 17:33 ` [PATCH 1/1] x86: Fix Intel Edison module stuck reboot Andy Shevchenko
2018-02-27 10:07 ` Sebastian Panceac
2018-02-27 15:44 ` Andy Shevchenko
2018-02-28 9:40 ` [PATCH v3 " Sebastian Panceac
2018-02-28 10:47 ` Andy Shevchenko
2018-02-28 17:21 ` tip-bot for Sebastian Panceac [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-028091f82eefd5e84f81cef81a7673016ecbe78b@git.kernel.org \
--to=tipbot@zytor.com \
--cc=andy.shevchenko@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sebastian@resin.io \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).