From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: namhyung@kernel.org, fweisbec@gmail.com, wangnan0@huawei.com,
mingo@kernel.org, acme@redhat.com, kan.liang@intel.com,
jolsa@redhat.com, a.p.zijlstra@chello.nl, andi@firstfloor.org,
tglx@linutronix.de, hpa@zytor.com, dsahern@gmail.com,
linux-kernel@vger.kernel.org
Subject: [tip:perf/core] perf top: Fix freeze on --call-graph flat/folded
Date: Thu, 26 Nov 2015 23:43:29 -0800 [thread overview]
Message-ID: <tip-0356218a68551f051998f4fb5074a1eed7a346fe@git.kernel.org> (raw)
In-Reply-To: <1448521700-32062-1-git-send-email-namhyung@kernel.org>
Commit-ID: 0356218a68551f051998f4fb5074a1eed7a346fe
Gitweb: http://git.kernel.org/tip/0356218a68551f051998f4fb5074a1eed7a346fe
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Thu, 26 Nov 2015 16:08:18 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 26 Nov 2015 13:32:08 -0300
perf top: Fix freeze on --call-graph flat/folded
The callchain rbtree is rebuilt periodically, so it needs to
reinitialize the root everytime. Otherwise it can be stuck in the
rbtree insertion with stale pointers.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1448521700-32062-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/callchain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index fc3b1e0..564377d 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -290,6 +290,7 @@ static void
sort_chain_flat(struct rb_root *rb_root, struct callchain_root *root,
u64 min_hit, struct callchain_param *param __maybe_unused)
{
+ *rb_root = RB_ROOT;
__sort_chain_flat(rb_root, &root->node, min_hit);
}
prev parent reply other threads:[~2015-11-27 7:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 7:08 [PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded Namhyung Kim
2015-11-26 7:08 ` [PATCH 2/3] perf callchain: Stop resolving callchains after invalid address Namhyung Kim
2015-11-26 7:43 ` Ingo Molnar
2015-11-26 14:12 ` Namhyung Kim
2015-11-27 7:48 ` Ingo Molnar
2015-11-26 13:14 ` David Ahern
2015-11-26 15:00 ` Namhyung Kim
2015-11-26 15:48 ` David Ahern
2015-11-26 15:58 ` Jiri Olsa
2015-11-26 16:19 ` Arnaldo Carvalho de Melo
2015-12-02 5:20 ` Namhyung Kim
2015-11-26 7:08 ` [PATCH 3/3] perf callchain: Honor hide_unresolved Namhyung Kim
2015-11-26 8:46 ` Jiri Olsa
2015-11-26 16:20 ` Arnaldo Carvalho de Melo
2015-11-27 7:43 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-11-26 8:38 ` [PATCH 1/3] perf top: Fix freeze on --call-graph flat/folded Jiri Olsa
2015-11-26 13:52 ` Namhyung Kim
2015-11-26 14:00 ` Jiri Olsa
2015-11-26 15:10 ` Namhyung Kim
2015-11-26 15:22 ` Jiri Olsa
2015-11-26 16:32 ` Arnaldo Carvalho de Melo
2015-11-27 7:43 ` tip-bot for Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-0356218a68551f051998f4fb5074a1eed7a346fe@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox