From: tip-bot for Ard Biesheuvel <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, mka@chromium.org,
tglx@linutronix.de, torvalds@linux-foundation.org,
ard.biesheuvel@linaro.org, matt@codeblueprint.co.uk,
mingo@kernel.org
Subject: [tip:efi/core] efi/libstub/arm64: Force 'hidden' visibility for section markers
Date: Mon, 21 Aug 2017 02:16:21 -0700 [thread overview]
Message-ID: <tip-0426a4e68f18d75515414361de9e3e1445d2644e@git.kernel.org> (raw)
In-Reply-To: <20170818194947.19347-4-ard.biesheuvel@linaro.org>
Commit-ID: 0426a4e68f18d75515414361de9e3e1445d2644e
Gitweb: http://git.kernel.org/tip/0426a4e68f18d75515414361de9e3e1445d2644e
Author: Ard Biesheuvel <ard.biesheuvel@linaro.org>
AuthorDate: Fri, 18 Aug 2017 20:49:36 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 21 Aug 2017 09:43:49 +0200
efi/libstub/arm64: Force 'hidden' visibility for section markers
To prevent the compiler from emitting absolute references to the section
markers when running in PIC mode, override the visibility to 'hidden' for
all contents of asm/sections.h
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20170818194947.19347-4-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
drivers/firmware/efi/libstub/arm64-stub.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/libstub/arm64-stub.c b/drivers/firmware/efi/libstub/arm64-stub.c
index b4c2589..f7a6970 100644
--- a/drivers/firmware/efi/libstub/arm64-stub.c
+++ b/drivers/firmware/efi/libstub/arm64-stub.c
@@ -9,9 +9,17 @@
* published by the Free Software Foundation.
*
*/
+
+/*
+ * To prevent the compiler from emitting GOT-indirected (and thus absolute)
+ * references to the section markers, override their visibility as 'hidden'
+ */
+#pragma GCC visibility push(hidden)
+#include <asm/sections.h>
+#pragma GCC visibility pop
+
#include <linux/efi.h>
#include <asm/efi.h>
-#include <asm/sections.h>
#include <asm/sysreg.h>
#include "efistub.h"
next prev parent reply other threads:[~2017-08-21 9:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 19:49 [GIT PULL 00/14] EFI changes for v4.14 Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 01/14] efi: arm: Don't mark ACPI reclaim memory as MEMBLOCK_NOMAP Ard Biesheuvel
2017-08-21 9:15 ` [tip:efi/core] efi/arm: " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 02/14] efi/libstub: arm64: use hidden attribute for struct screen_info reference Ard Biesheuvel
2017-08-21 9:15 ` [tip:efi/core] efi/libstub/arm64: Use " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 03/14] efi/libstub: arm64: force 'hidden' visibility for section markers Ard Biesheuvel
2017-08-21 9:16 ` tip-bot for Ard Biesheuvel [this message]
2017-08-18 19:49 ` [PATCH 04/14] efi/libstub: arm64: set -fpie when building the EFI stub Ard Biesheuvel
2017-08-21 9:16 ` [tip:efi/core] efi/libstub/arm64: Set " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 05/14] efi: arm/arm64: Add missing assignment of efi.config_table Ard Biesheuvel
2017-08-21 9:17 ` [tip:efi/core] efi/arm/arm64: " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 06/14] efi/reboot: Fall back to original power-off method if EFI_RESET_SHUTDOWN returns Ard Biesheuvel
2017-08-21 9:17 ` [tip:efi/core] " tip-bot for Hans de Goede
2017-08-18 19:49 ` [PATCH 07/14] drivers/fbdev: efifb: allow BAR to be moved instead of claiming it Ard Biesheuvel
2017-08-21 9:17 ` [tip:efi/core] drivers/fbdev/efifb: Allow " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 08/14] arm: efi: remove forbidden values from the PE/COFF header Ard Biesheuvel
2017-08-21 9:18 ` [tip:efi/core] arm/efi: Remove " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 09/14] arm: efi: remove pointless dummy .reloc section Ard Biesheuvel
2017-08-21 9:18 ` [tip:efi/core] arm/efi: Remove " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 10/14] arm: efi: replace open coded constants with symbolic ones Ard Biesheuvel
2017-08-21 9:19 ` [tip:efi/core] arm/efi: Replace " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 11/14] arm: efi: split zImage code and data into separate PE/COFF sections Ard Biesheuvel
2017-08-21 9:19 ` [tip:efi/core] arm/efi: Split " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 12/14] firmware: dcdbas: constify attribute_group structures Ard Biesheuvel
2017-08-21 9:19 ` [tip:efi/core] firmware/dcdbas: Constify " tip-bot for Arvind Yadav
2017-08-18 19:49 ` [PATCH 13/14] firmware: efi: constify " Ard Biesheuvel
2017-08-21 9:20 ` [tip:efi/core] firmware/efi: Constify " tip-bot for Arvind Yadav
2017-08-18 19:49 ` [PATCH 14/14] firmware: efi: esrt: constify " Ard Biesheuvel
2017-08-21 9:20 ` [tip:efi/core] firmware/efi/esrt: Constify " tip-bot for Arvind Yadav
2017-08-21 9:34 ` [GIT PULL 00/14] EFI changes for v4.14 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-0426a4e68f18d75515414361de9e3e1445d2644e@git.kernel.org \
--to=tipbot@zytor.com \
--cc=ard.biesheuvel@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=mka@chromium.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox