public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Yinghai Lu <yinghai@kernel.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	yinghai@kernel.org, suresh.b.siddha@intel.com,
	tglx@linutronix.de, ebiederm@xmission.com
Subject: [tip:x86/apic-cleanups] x86, x2apic: Don't map lapic addr for preenabled x2apic systems
Date: Thu, 9 Dec 2010 20:56:10 GMT	[thread overview]
Message-ID: <tip-0450193bffed6e4b6160c4a5ccb0df158eba7d2a@git.kernel.org> (raw)
In-Reply-To: <4CFDF69C.9070501@kernel.org>

Commit-ID:  0450193bffed6e4b6160c4a5ccb0df158eba7d2a
Gitweb:     http://git.kernel.org/tip/0450193bffed6e4b6160c4a5ccb0df158eba7d2a
Author:     Yinghai Lu <yinghai@kernel.org>
AuthorDate: Tue, 7 Dec 2010 00:55:56 -0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 9 Dec 2010 21:52:05 +0100

x86, x2apic: Don't map lapic addr for preenabled x2apic systems

If x2apic is preenabled and used by the kernel, we don't need to map
the lapic address. That mapping will never be used.

So just skip that in register_lapic_address()

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
LKML-Reference: <4CFDF69C.9070501@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 arch/x86/kernel/apic/apic.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 9303364..8933936 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1681,9 +1681,11 @@ void __init register_lapic_address(unsigned long address)
 {
 	mp_lapic_addr = address;
 
-	set_fixmap_nocache(FIX_APIC_BASE, address);
-	apic_printk(APIC_VERBOSE, "mapped APIC to %16lx (%16lx)\n",
-		    APIC_BASE, mp_lapic_addr);
+	if (!x2apic_mode) {
+		set_fixmap_nocache(FIX_APIC_BASE, address);
+		apic_printk(APIC_VERBOSE, "mapped APIC to %16lx (%16lx)\n",
+			    APIC_BASE, mp_lapic_addr);
+	}
 	if (boot_cpu_physical_apicid == -1U) {
 		boot_cpu_physical_apicid  = read_apic_id();
 		apic_version[boot_cpu_physical_apicid] =

      reply	other threads:[~2010-12-09 20:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4CFDF544.8020309@kernel.org>
2010-12-07  8:55 ` [PATCH 1/5] x86, apic: Merge two register_lapic_address() Yinghai Lu
2010-12-09 20:54   ` [tip:x86/apic-cleanups] x86, apic: Unify identical register_lapic_address() functions tip-bot for Yinghai Lu
2010-12-07  8:55 ` [PATCH 2/5] x86, apic: Remove early_init_lapic_mapping Yinghai Lu
2010-12-09 20:55   ` [tip:x86/apic-cleanups] x86, apic: Remove early_init_lapic_mapping() tip-bot for Yinghai Lu
2010-12-07  8:55 ` [PATCH 3/5] x86, apic: Use register_lapic_address in init_apic_mapping Yinghai Lu
2010-12-09 20:55   ` [tip:x86/apic-cleanups] x86, apic: Use register_lapic_address() in init_apic_mapping() tip-bot for Yinghai Lu
2010-12-07  8:55 ` [PATCH 4/5] x86, sfi: Use register_lapic_address() Yinghai Lu
2010-12-09 20:55   ` [tip:x86/apic-cleanups] " tip-bot for Yinghai Lu
2010-12-07  8:55 ` [PATCH 5/5] x86, x2apic: Don't map lapic addr for preenabled x2apic system Yinghai Lu
2010-12-09 20:56   ` tip-bot for Yinghai Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-0450193bffed6e4b6160c4a5ccb0df158eba7d2a@git.kernel.org \
    --to=yinghai@kernel.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox