From: tip-bot for Adrien Schildknecht <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: torvalds@linux-foundation.org, bp@suse.de,
adrien+dev@schischi.me, mingo@kernel.org, tglx@linutronix.de,
hpa@zytor.com, rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: [tip:x86/debug] x86/kernel: Use kstack_end() in dumpstack_64.c
Date: Tue, 3 Mar 2015 03:28:53 -0800 [thread overview]
Message-ID: <tip-04769ae3ac72f86324a189b69f53bf3bfb61acfd@git.kernel.org> (raw)
In-Reply-To: <1424618638-6375-1-git-send-email-adrien+dev@schischi.me>
Commit-ID: 04769ae3ac72f86324a189b69f53bf3bfb61acfd
Gitweb: http://git.kernel.org/tip/04769ae3ac72f86324a189b69f53bf3bfb61acfd
Author: Adrien Schildknecht <adrien+dev@schischi.me>
AuthorDate: Sun, 22 Feb 2015 16:23:58 +0100
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Mon, 23 Feb 2015 18:37:13 +0100
x86/kernel: Use kstack_end() in dumpstack_64.c
i386 is already using kstack_end() in dumpstack_32.c. We should also
use it to make the code clearer and unify the stack printing logic some
more.
Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: c: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1424618638-6375-1-git-send-email-adrien+dev@schischi.me
Signed-off-by: Borislav Petkov <bp@suse.de>
---
arch/x86/kernel/dumpstack_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/dumpstack_64.c b/arch/x86/kernel/dumpstack_64.c
index 553573b..5f1c626 100644
--- a/arch/x86/kernel/dumpstack_64.c
+++ b/arch/x86/kernel/dumpstack_64.c
@@ -280,7 +280,7 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs,
pr_cont(" <EOI> ");
}
} else {
- if (((long) stack & (THREAD_SIZE-1)) == 0)
+ if (kstack_end(stack))
break;
}
if ((i % STACKSLOTS_PER_LINE) == 0) {
prev parent reply other threads:[~2015-03-03 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 15:23 [PATCH] x86_64: use kstack_end() in dumpstack_64.c Adrien Schildknecht
2015-02-23 17:17 ` Steven Rostedt
2015-02-23 17:20 ` Borislav Petkov
2015-02-23 17:29 ` Adrien Schildknecht
2015-02-23 17:54 ` Steven Rostedt
2015-02-23 18:02 ` Borislav Petkov
2015-03-03 11:28 ` tip-bot for Adrien Schildknecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-04769ae3ac72f86324a189b69f53bf3bfb61acfd@git.kernel.org \
--to=tipbot@zytor.com \
--cc=adrien+dev@schischi.me \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox