From: tip-bot for Li Zefan <lizf@cn.fujitsu.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, acme@redhat.com, hpa@zytor.com,
mingo@redhat.com, lizf@cn.fujitsu.com, jens.axboe@oracle.com,
fweisbec@gmail.com, rostedt@goodmis.org, tglx@linutronix.de,
mingo@elte.hu
Subject: [tip:tracing/core] blktrace: pdu_buf of pc events should be unsigned
Date: Mon, 11 May 2009 10:27:30 GMT [thread overview]
Message-ID: <tip-049862579333cc6cd9e6edfd6987cd0addfd8c59@git.kernel.org> (raw)
In-Reply-To: <4A07C6B3.9080802@cn.fujitsu.com>
Commit-ID: 049862579333cc6cd9e6edfd6987cd0addfd8c59
Gitweb: http://git.kernel.org/tip/049862579333cc6cd9e6edfd6987cd0addfd8c59
Author: Li Zefan <lizf@cn.fujitsu.com>
AuthorDate: Mon, 11 May 2009 14:33:23 +0800
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 11 May 2009 12:25:50 +0200
blktrace: pdu_buf of pc events should be unsigned
I got this:
8,0 1 305.417782332 2037 I R 32 (ffffff9e 10 00 ...) [bash]
It should be:
8,0 1 305.417782332 2037 I R 32 (9e 10 00 ...) [bash]
[ Impact: fix output of pc events ]
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <4A07C6B3.9080802@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/trace/blktrace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index e099f8c..05b4747 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -1065,7 +1065,7 @@ static int blk_log_action(struct trace_iterator *iter, const char *act)
static int blk_log_dump_pdu(struct trace_seq *s, const struct trace_entry *ent)
{
- const char *pdu_buf;
+ const unsigned char *pdu_buf;
int pdu_len;
int i, end, ret;
prev parent reply other threads:[~2009-05-11 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 6:33 [PATCH] blktrace: pdu_buf of pc events should be unsigned Li Zefan
2009-05-11 10:27 ` tip-bot for Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-049862579333cc6cd9e6edfd6987cd0addfd8c59@git.kernel.org \
--to=lizf@cn.fujitsu.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox