public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Daniel Kiper <dkiper@net-space.pl>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	dkiper@net-space.pl, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/urgent] x86, apic: Fix apic=debug boot crash
Date: Fri, 20 Aug 2010 12:41:24 GMT	[thread overview]
Message-ID: <tip-05e407603e527f9d808dd3866d3a17c2ce4dfcc5@git.kernel.org> (raw)
In-Reply-To: <20100819224616.GB9967@router-fw-old.local.net-space.pl>

Commit-ID:  05e407603e527f9d808dd3866d3a17c2ce4dfcc5
Gitweb:     http://git.kernel.org/tip/05e407603e527f9d808dd3866d3a17c2ce4dfcc5
Author:     Daniel Kiper <dkiper@net-space.pl>
AuthorDate: Fri, 20 Aug 2010 00:46:16 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 20 Aug 2010 10:18:28 +0200

x86, apic: Fix apic=debug boot crash

Fix a boot crash when apic=debug is used and the APIC is
not properly initialized.

This issue appears during Xen Dom0 kernel boot but the
fix is generic and the crash could occur on real hardware
as well.

Signed-off-by: Daniel Kiper <dkiper@net-space.pl>
Cc: xen-devel@lists.xensource.com
Cc: konrad.wilk@oracle.com
Cc: jeremy@goop.org
Cc: <stable@kernel.org> # .35.x, .34.x, .33.x, .32.x
LKML-Reference: <20100819224616.GB9967@router-fw-old.local.net-space.pl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/apic/io_apic.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 4dc0084..f1efeba 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1728,6 +1728,8 @@ __apicdebuginit(void) print_IO_APIC(void)
 		struct irq_pin_list *entry;
 
 		cfg = desc->chip_data;
+		if (!cfg)
+			continue;
 		entry = cfg->irq_2_pin;
 		if (!entry)
 			continue;

  reply	other threads:[~2010-08-20 12:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19 22:46 [PATCH] arch/x86/kernel/apic/io_apic.c: Fix for crash when apic=debug is used Daniel Kiper
2010-08-20 12:41 ` tip-bot for Daniel Kiper [this message]
2010-08-20 19:24   ` [tip:x86/urgent] x86, apic: Fix apic=debug boot crash Yinghai Lu
2010-08-23  8:12     ` Daniel Kiper
2010-08-23 14:54       ` H. Peter Anvin
2010-08-23 17:59         ` Yinghai Lu
2010-08-24 21:39           ` Daniel Kiper
2010-08-24 21:47             ` Yinghai Lu
2010-08-25 13:51               ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-05e407603e527f9d808dd3866d3a17c2ce4dfcc5@git.kernel.org \
    --to=dkiper@net-space.pl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox